Ticket #7043 (closed bug: fixed)
Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed
| Reported by: | andrew1 | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.8.14 |
| Component: | ui.datepicker | Version: | 1.8.10 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description (last modified by scott.gonzalez) (diff)
Firstly - great work!
Bug. When selecting to use multiple months with the datepicker there appears to be an erroneous extra row of empty cells a the bottom effectively padding the bottom unnessarily.
kind regards Andrew Blake - beginner level so sorry if off track
Change History
comment:1 Changed 2 years ago by scott.gonzalez
- Status changed from new to open
- Description modified (diff)
- Summary changed from ui datepicker extra row with muliple months. to Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed
comment:3 Changed 2 years ago by Scott González
- Status changed from open to closed
- Resolution set to fixed
Merge pull request #223 from kzys/trac-7043
Fixed #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are neededf
Changeset: d3e21cf59ab6273f9b080c56afbc71fcf76139da
comment:4 Changed 2 years ago by Kato Kazuyoshi
Datepicker: Fixed #7043 - Using multiple months always renders 6 rows of dates even if only 5 are needed. (cherry picked from commit ac459ff7df4904cb8601d4efb95107177ecb40e0)
Changeset: 5e1032ec74feba976c91de275605174c87710a6a
comment:6 Changed 2 years ago by ThiefMaster
Uh.. depending on the months displayed the additional row is necessary - otherwise it might look bad since the single calendars would have different row counts.
While http://i.imgur.com/sPHe3.png is not a multi-month calendar it shows pretty much how it would look like.
comment:7 Changed 2 years ago by scott.gonzalez
- Status changed from closed to reopened
- Resolution fixed deleted
Thanks ThiefMaster, we were trying to figure out why it was hard-coded to 6 rows before, but the logic wasn't documented at all.
So a proper fix would render the number of months of the tallest month being rendered.
comment:8 Changed 2 years ago by Scott González
- Status changed from reopened to closed
- Resolution set to fixed
Revert "Datepicker: Fixed #7043 - Using multiple months always renders 6 rows of dates even if only 5 are needed."
This reverts commit ac459ff7df4904cb8601d4efb95107177ecb40e0.
Changeset: 1845015c09d527abde8095f8e2209f06d879a2b3
comment:9 Changed 2 years ago by Scott González
Revert "Datepicker: Fixed #7043 - Using multiple months always renders 6 rows of dates even if only 5 are needed."
This reverts commit 5e1032ec74feba976c91de275605174c87710a6a.
Changeset: 804ba0a2df3a98db5929474daa3f664b7a3d5f29
comment:10 Changed 2 years ago by scott.gonzalez
- Status changed from closed to reopened
- Resolution fixed deleted
- Milestone changed from 1.8.13 to 1.9
comment:11 Changed 2 years ago by Scott González
- Status changed from reopened to closed
- Resolution set to fixed
Merge pull request #353 from kborchers/bug_7043
Datepicker: Calculate the max number of rows necessary when displaying months. Fixes #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed
Changeset: fb210ae1ec16cefb1e4d4dfaf7d55499cac53ab8
comment:13 Changed 2 years ago by kborchers
Datepicker: Calculate the max number of rows necessary when displaying months. Fixes #7043 - Datepicker: Using multiple months always renders 6 rows of dates even if only 5 are needed (cherry picked from commit 1d984e76b79bfeda15eff392e06d8ed0eab72333)
Changeset: 57b9e9d399fd5e04d60428ed98f585e49373dc85