Ticket #7103 (closed enhancement: fixed)
Effects: Move effects to $.effects.effect[]
| Reported by: | gnarf | Owned by: | gnarf |
|---|---|---|---|
| Priority: | major | Milestone: | 1.9.0 |
| Component: | ui.effects.core | Version: | 1.8.10 |
| Keywords: | Cc: | ||
| Blocking: | #7105 | Blocked by: |
Description (last modified by gnarf) (diff)
Part 2 of http://bugs.jqueryui.com/ticket/7060#comment:4 as its own ticket:
In thinking about how to handle the BC shim for this API change, and other ways we might clean up the internal API - I thought we could move the actual effect implementation functions out of the $.effects[] and into $.effects.effect[] . It gives us a discreet namespace where we are sure that the function is an effect API function. Currently, other functions exist out on $.effects[] that aren't effects, allowing you to get interesting results for $("div").toggle("animateClass") - Letting that namespace hold utility functions, while pushing the actual effects into a new namespace could show some minor improvements.
Change History
comment:2 Changed 2 years ago by gnarf
- Priority changed from minor to major
- Description modified (diff)
comment:5 Changed 2 years ago by scott.gonzalez
- Summary changed from Improving Internal Effects API - Part 2 to Effects: Move effects to $.effects.effect[]
comment:5 Changed 2 years ago by gnarf
- Status changed from assigned to closed
- Resolution set to fixed
Effects: Moved effects to $.effects.effect[] and deprecated use of $.effects[]. Fixes #7103 - Effects: Move effects to $.effects.effect[].
Changeset: d64c9efda53f6e56feacf5f39940cd7719a2cb61
comment:6 Changed 2 years ago by gnarf
Datepicker: Updated to check for new or old style effects (see #7103).
Changeset: ac0cc2fac5c0be1be599e35524476718be1650e3
Moving jQuery.sub() to another ticket per scotts request - leaving only $.effects.effect[] on this ticket: http://bugs.jqueryui.com/ticket/7105 contains the other part...