Ticket #7257 (closed enhancement: fixed)

Opened 4 years ago

Last modified 3 years ago

Core: optimize :tabbable

Reported by: adambaratz Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.core Version: 1.8.11
Keywords: Cc:
Blocking: Blocked by:

Description

The :tabbable selector is dependent on the :focusable selector. Both pull the tabindex attribute on each element they check. Some milliseconds can be shaved by reusing this value. It's a slight gain, but since :tabbable is run during Dialog initialization, complex dialogs can have real gains from this.

Change History

comment:2 Changed 3 years ago by adambaratz

  • Status changed from new to closed
  • Resolution set to fixed

Core: reuse tabindex value. Fixed #7257 - optimize :tabbable.

Changeset: fe3b36b8efcabf3d1f1d60523cae87c69a882f27

comment:3 Changed 3 years ago by adambaratz

Core: reuse tabindex value. Fixed #7257 - optimize :tabbable. (cherry picked from commit fe3b36b8efcabf3d1f1d60523cae87c69a882f27)

Changeset: 96f6b1a7db1e3bc74de66153cf9be80152e04430

comment:4 Changed 3 years ago by ohlavacek

This still performs very poorly (eg Firefox 5 on a new dialog with 300 elements takes around 5 seconds).

Note: See TracTickets for help on using tickets.