Ticket #7318 (closed feature: fixed)

Opened 2 years ago

Last modified 2 years ago

Add the queue functions to $.fn.effect()

Reported by: gnarf Owned by: gnarf
Priority: major Milestone: 1.9.0
Component: ui.effects.core Version: 1.8.12
Keywords: Cc:
Blocking: Blocked by:

Description (last modified by gnarf) (diff)

Every effect in effects.effect returns this.queue(). We could DRY out the effects a bit while we are upgrading to 1.9 if we were to handle the "queue" issues in the main effects function.

Change History

comment:1 Changed 2 years ago by gnarf

  • Owner set to gnarf
  • Priority changed from minor to major
  • Status changed from new to assigned
  • Description modified (diff)

comment:2 Changed 2 years ago by scott.gonzalez

  • Type changed from bug to feature

comment:3 Changed 2 years ago by gnarf

Further amending this... All of the effects also are handing calling the complete callback - after putting the queue stuff into $.fn.effect its now possible to wrap the complete function up with it and just pass one done argument for the effect to call when it finishes.

comment:4 Changed 2 years ago by gnarf

  • Status changed from assigned to closed
  • Resolution set to fixed

Effects.*: Updating Effect Method API to avoid duplicating the queue call - Fixes #7318 - Add the queue functions to $.fn.effect()

Changeset: 1c1a3b1a361d90a73755fbd038b3cdfb0960c29f

Note: See TracTickets for help on using tickets.