Search and Top Navigation
#7430 closed bug (fixed)
Opened May 27, 2011 04:19PM UTC
Closed August 18, 2014 11:54PM UTC
Draggable: _adjustOffsetFromHelper not reinvoked after "start" event is fired
Reported by: | marcel.jackwerth | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.11.2 |
Component: | ui.draggable | Version: | 1.8.13 |
Keywords: | haspatch | Cc: | |
Blocked by: | Blocking: |
Description
While _cacheHelperProportions is reinvoked after the start-event, _adjustOffsetFromHelper is not. This leads to issues if you use right/bottom offsets (which depend on width/height) and you modify the helper (or it's content) during the start-event.
Here's the code of draggables mouseStart (removed irrelevant code for this problem)
//Cache the helper size this._cacheHelperProportions(); //Adjust the mouse offset relative to the helper if 'cursorAt' is supplied (o.cursorAt && this._adjustOffsetFromHelper(o.cursorAt)); //Recache the helper size this._cacheHelperProportions();
This could be fixed if we just add another _adjustOffsetFromHelper after the re-caching or are there any side-effects I am missing?
this._cacheHelperProportions(); (o.cursorAt && this._adjustOffsetFromHelper(o.cursorAt));
Attachments (0)
Change History (3)
Changed October 11, 2012 02:49PM UTC by comment:1
milestone: | 1.9.0 → 2.0.0 |
---|
Changed October 27, 2012 08:09PM UTC by comment:2
keywords: | → haspatch |
---|---|
status: | new → open |
summary: | _adjustOffsetFromHelper not reinvoked after start-event → Draggable: _adjustOffsetFromHelper not reinvoked after "start" event is fired |
This makes sense. The offset should be adjusted after the start event is fired.