Ticket #7564 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

alignValue Global Scope

Reported by: be.davestein Owned by:
Priority: minor Milestone: 1.8.15
Component: ui.slider Version: 1.8.14
Keywords: Cc:
Blocking: Blocked by:

Description

_trimAlignValue is returning alignValue, but never uses a var statement within the function. Found it while reviewing my code in the DOM tab of Firebug.

Change History

comment:1 Changed 3 years ago by rdworth

  • Status changed from new to closed
  • Resolution set to invalid

step, valModStep and alignValue all share a single var statement. See lines 578-580

		var step = ( this.options.step > 0 ) ? this.options.step : 1,
			valModStep = (val - this._valueMin()) % step,
			alignValue = val - valModStep;

comment:2 Changed 3 years ago by scott.gonzalez

  • Status changed from closed to reopened
  • Resolution invalid deleted

This is definitely broken in 1.8.x.

comment:3 Changed 3 years ago by Scott González

  • Status changed from reopened to closed
  • Resolution set to fixed

Slider: Fixed var statement. Fixes #7564 - alignValue Global Scope.

Changeset: 8d43fe7e3428e4fb4e5d9ca9e76a0d5078dfe708

comment:4 Changed 3 years ago by scott.gonzalez

  • Milestone changed from 1.9 to 1.8.15
Note: See TracTickets for help on using tickets.