Ticket #7613 (closed bug: fixed)
Incorrect UI keyCodes
| Reported by: | be.davestein | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.0 |
| Component: | ui.core | Version: | 1.8.14 |
| Keywords: | Cc: | ||
| Blocking: | Blocked by: |
Description
Apparently in Firefox Mac, COMMAND keyCode is 224. Everywhere else is 91 as the constants currently show in ui.core.
Change History
comment:2 Changed 22 months ago by scott.gonzalez
Opera and Firefox also don't differentiate between the left and right command keys.
comment:3 Changed 22 months ago by be.davestein
instead of e.keyCode === $.ui.keyCode.COMMAND, maybe the breaking change of $.ui.keyCode.isCommand( e.keyCode ) would be better for future proofing?
comment:4 Changed 22 months ago by scott.gonzalez
well, we should probably just use the event properties and fix event.metaKey
comment:5 Changed 16 months ago by Scott González
- Status changed from new to closed
- Resolution set to fixed
Core: Removed modifier keys from key codes. Fixed #7613 - Incorrect UI keyCodes.
Changeset: 8dcb02d03598b75204227b5c187d8b6e8d33b03d
Note: See
TracTickets for help on using
tickets.
Opera reports the keyCode as 17, perhaps we should define these keys and just rely on the event properties.