Ticket #7795 (closed enhancement: fixed)

Opened 19 months ago

Last modified 11 months ago

Widget: _on and _off

Reported by: gnarf Owned by:
Priority: minor Milestone: git
Component: ui.widget Version: git
Keywords: Cc:
Blocking: Blocked by:

Description

Should we adopt the naming from 1.7 core and start using _on instead of _bind and create a _off to unbind them?

We found a use for having a _off while we were doing a review of the Draggable interactions

Change History

comment:1 Changed 15 months ago by joern.zaefferer

What was the usecase for _off?

comment:2 Changed 15 months ago by scott.gonzalez

We dynamically bind and unbind for move and stop events.

comment:3 Changed 15 months ago by joern.zaefferer

  • Status changed from new to open

Should give that a try as part of interactions rewrite.

comment:4 Changed 11 months ago by scott.gonzalez

Renamed _bind() to _on() in 9608e981498846b3727cc4dad723a7fa7252fd86.

comment:5 Changed 11 months ago by Scott González

  • Status changed from open to closed
  • Resolution set to fixed

Widget: Added _off() for removing event handlers. Fixes #7795 - Widget: _on and _off.

Changeset: ff39bed57a05ca060033187b8aecebafab357f78

comment:6 Changed 11 months ago by scott.gonzalez

  • Milestone changed from 1.9 to git
Note: See TracTickets for help on using tickets.