Ticket #7838 (closed bug: fixed)

Opened 3 years ago

Last modified 3 years ago

Clearfix breaks after runs through YUI Compressor

Reported by: shnitz Owned by:
Priority: minor Milestone: 1.8.17
Component: ui.css-framework Version: 1.8.16
Keywords: Cc:
Blocking: Blocked by:

Description

I minify my CSS files through YUICompressor, my build script creats a minified ui.css file with all my jQuery UI css, and then pulls that into a main css file with all my sites code, minifying again, what results is this,

Original CSS:

.ui-helper-clearfix { display: inline-block; }
/* required comment for clearfix to work in Opera \*/
* html .ui-helper-clearfix { height:1%; }
.ui-helper-clearfix { display:block; }
/* end clearfix */

After one run becoming this,

.ui-helper-clearfix{display:inline-block}/*\*/* html .ui-helper-clearfix{height:1%}.ui-helper-clearfix{display:block}/**/

And the second run,

.ui-helper-clearfix{display:inline-block}/*\*/**/

I don't know if there is anything you can (or should) do to prevent this, I couldn't find any documentation about the opera comment so I'm hesitant to touch it.

How disruptive would it be to use a newer clearfix?  http://nicolasgallagher.com/micro-clearfix-hack/

Change History

comment:1 Changed 3 years ago by scott.gonzalez

  • Component changed from ui.core to CSS Framework

comment:2 Changed 3 years ago by Richard D. Worth

  • Status changed from new to closed
  • Resolution set to fixed

Theme base core: Updated clearfix to 'new micro clearfix hack' by Nicolas Gallagher  http://nicolasgallagher.com/micro-clearfix-hack/ . Fixed #7838 - Clearfix breaks after runs through YUI Compressor

Changeset: c21a5b4451f5eded288de4482b9508e2bd13756d

comment:3 Changed 3 years ago by Richard D. Worth

Theme base core: Updated clearfix to 'new micro clearfix hack' by Nicolas Gallagher  http://nicolasgallagher.com/micro-clearfix-hack/ . Fixed #7838 - Clearfix breaks after runs through YUI Compressor (cherry picked from commit c21a5b4451f5eded288de4482b9508e2bd13756d)

Changeset: 6f6e2ded1a9b30f65a34733f3d887c16c162e28a

comment:4 Changed 3 years ago by rdworth

Thanks for the tip shnitz !

comment:5 Changed 3 years ago by rdworth

  • Milestone changed from 1.9 to 1.8.17
Note: See TracTickets for help on using tickets.