#7838 closed bug (fixed)

Opened November 07, 2011 10:37PM UTC

Closed November 09, 2011 05:58PM UTC

Last modified November 09, 2011 06:02PM UTC

Clearfix breaks after runs through YUI Compressor

Reported by: shnitz Owned by:
Priority: minor Milestone: 1.8.17
Component: ui.css-framework Version: 1.8.16
Keywords: Cc:
Blocked by: Blocking:
Description

I minify my CSS files through YUICompressor, my build script creats a minified ui.css file with all my jQuery UI css, and then pulls that into a main css file with all my sites code, minifying again, what results is this,

Original CSS:

.ui-helper-clearfix { display: inline-block; }
/* required comment for clearfix to work in Opera \\*/
* html .ui-helper-clearfix { height:1%; }
.ui-helper-clearfix { display:block; }
/* end clearfix */

After one run becoming this,

.ui-helper-clearfix{display:inline-block}/*\\*/* html .ui-helper-clearfix{height:1%}.ui-helper-clearfix{display:block}/**/

And the second run,

.ui-helper-clearfix{display:inline-block}/*\\*/**/

I don't know if there is anything you can (or should) do to prevent this, I couldn't find any documentation about the opera comment so I'm hesitant to touch it.

How disruptive would it be to use a newer clearfix? http://nicolasgallagher.com/micro-clearfix-hack/

Attachments (0)
Change History (5)

Changed November 08, 2011 12:05AM UTC by scottgonzalez comment:1

component: ui.core → CSS Framework

Changed November 09, 2011 05:58PM UTC by Richard D. Worth comment:2

resolution: → fixed
status: new → closed

Theme base core: Updated clearfix to 'new micro clearfix hack' by Nicolas Gallagher http://nicolasgallagher.com/micro-clearfix-hack/ . Fixed #7838 - Clearfix breaks after runs through YUI Compressor

Changeset: c21a5b4451f5eded288de4482b9508e2bd13756d

Changed November 09, 2011 05:59PM UTC by Richard D. Worth comment:3

Theme base core: Updated clearfix to 'new micro clearfix hack' by Nicolas Gallagher http://nicolasgallagher.com/micro-clearfix-hack/ . Fixed #7838 - Clearfix breaks after runs through YUI Compressor

(cherry picked from commit c21a5b4451f5eded288de4482b9508e2bd13756d)

Changeset: 6f6e2ded1a9b30f65a34733f3d887c16c162e28a

Changed November 09, 2011 06:00PM UTC by rdworth comment:4

Thanks for the tip shnitz !

Changed November 09, 2011 06:02PM UTC by rdworth comment:5

milestone: 1.9 → 1.8.17