Search and Top Navigation
#8267 closed bug (fixed)
Opened April 20, 2012 09:04PM UTC
Closed June 15, 2012 11:35AM UTC
Last modified June 15, 2012 11:40AM UTC
dialog fadein broken since 1.9m4
| Reported by: | chadw | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | git |
| Component: | ui.effects.* (individual effect) | Version: | git (not yet released) |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
$.effects.effect.fade changed between 1.9m4 and 1.9m5. Since then, I am unable to get a dialog to fade in (fade out works). Perhaps a CSS tweak didn't make it to the dialog widget? The .show() is suspicious otherwise.
Changing jquery.effects.fade.js:
el.show();
el.animate({
opacity: hide ? 0 : 1
To this:
// el.show();
el.animate({
opacity: hide ? 'hide' : 'show'
Fixes it.
Attachments (0)
Change History (3)
Changed April 21, 2012 02:13PM UTC by comment:1
Changed June 15, 2012 11:35AM UTC by comment:2
| resolution: | → fixed |
|---|---|
| status: | new → closed |
Effects (fade): Delegate hiding and showing to core. Fixes #8267 - dialog fadein broken since 1.9m4.
Changeset: d569b52838594c3e7e732d31dbf07dc2072edfdb
Changed June 15, 2012 11:40AM UTC by comment:3
| milestone: | 1.9 → git |
|---|
Fade changed in 1eada2154910102e4c39d131a23af24ad0d92815 with no description of what the problem actually was, but looking at the test failure from the previous commit should provide enough insight.