#8301 closed feature (fixed)

Opened May 07, 2012 04:02PM UTC

Closed March 23, 2013 07:44PM UTC

Last modified April 17, 2013 06:50PM UTC

Sortable: Placeholder doesn't move when using connectWith option

Reported by:	MoonScript	Owned by:
Priority:	minor	Milestone:	1.10.3
Component:	ui.sortable	Version:	1.8.20
Keywords:		Cc:
Blocked by:		Blocking:

Description

This is the same issue that was reported in #8274, but for connected lists (when using the "connectWith" option).

Issue can be seen here:

http://jsfiddle.net/MoonScript/eba5T/show/

And I believe it should work like this:

http://jsfiddle.net/MoonScript/eba5T/4/show/

Attachments (0)

Change History (12)

Changed May 07, 2012 04:19PM UTC by MoonScript comment:1

_comment0:	Pull request with fix here: \ https://github.com/jquery/jquery-ui/pull/650 → 1363878008275361

Pull request with fix here:

https://github.com/jquery/jquery-ui/pull/941

Changed June 26, 2012 01:24AM UTC by scottgonzalez comment:2

type:	enhancement → feature

Changed October 11, 2012 02:56PM UTC by scottgonzalez comment:3

milestone:	1.9.0 → 2.0.0

Changed November 05, 2012 12:44PM UTC by jzaefferer comment:4

status:	new → open

Consider for redesign.

Changed March 17, 2013 02:40AM UTC by tj.vantoll comment:5

summary:	Placeholder doesn't move when using connectWith option → Sortable: Placeholder doesn't move when using connectWith option

The test case showing the issue had some broken links so I fixed them and switched it to point at master: http://jsfiddle.net/tj_vantoll/GFLgF/.

The issue showing @MoonScript's fix could not be updated to master since his fix is embedded within a full jQuery UI include, but I fixed the broken CSS links: http://jsfiddle.net/tj_vantoll/LjR2P/.

Changed March 20, 2013 11:34PM UTC by MoonScript comment:6

_comment0:	It appears that this issue was fixed in version 1.10: \ https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.sortable.js#L557-558 \ \ Commit here: \ https://github.com/jquery/jquery-ui/commit/b8b0c528301ab2bfc49e36143a3c4f6451e58ccd \ \ Please close this ticket. → 1363835149899096

It appears that this issue was fixed in version 1.10:

https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.sortable.js#L557-558

Commit here:

https://github.com/jquery/jquery-ui/commit/b8b0c528301ab2bfc49e36143a3c4f6451e58ccd

UPDATE: My bad; I was looking at a previous commit of mine. Yes, this is still an open issue.

Changed March 21, 2013 02:48AM UTC by tj.vantoll comment:7

Replying to [comment:6 MoonScript]:

It appears that this issue was fixed in version 1.10: https://github.com/jquery/jquery-ui/blob/master/ui/jquery.ui.sortable.js#L557-558 Commit here: https://github.com/jquery/jquery-ui/commit/b8b0c528301ab2bfc49e36143a3c4f6451e58ccd Please close this ticket.

I'm still seeing the issue against master http://jsfiddle.net/tj_vantoll/GFLgF/.

Changed March 21, 2013 02:59PM UTC by MoonScript comment:8

Here's a new pull request with necessary tests!

https://github.com/jquery/jquery-ui/pull/941

Changed March 23, 2013 07:44PM UTC by Jason Moon comment:9

resolution:	→ fixed
status:	open → closed

Sortable: update placeholder when axis is x or y for connected lists. Fixed #8301 - Placeholder doesn't move when using connectWith option

Changeset: f306a826a4d3b4c36c3f86cb5feeee23bb0db4c3

Changed March 23, 2013 07:44PM UTC by mikesherov comment:10

milestone:	2.0.0 → 1.11.0

Changed April 17, 2013 06:50PM UTC by Jason Moon comment:11