Skip to main content

Search and Top Navigation

#8484 closed bug (fixed)

Opened August 10, 2012 09:30AM UTC

Closed August 10, 2012 01:29PM UTC

Last modified August 14, 2012 12:14PM UTC

Text of buttons in dialog is not shown with jquery 1.8.0

Reported by: matzes Owned by:
Priority: minor Milestone: 1.8.23
Component: ui.dialog Version: 1.8.22
Keywords: Cc:
Blocked by: Blocking:
Description

The text of buttons in dialog will not appear when used with jquery 1.8.0. Only an empty button is shown. http://jsbin.com/esokix/3

Works as expected with jquery 1.7.2 http://jsbin.com/esokix/2

$("#dlg").dialog({
  buttons: [
    {
      text: "close"
    }
  ]
});
Attachments (0)
Change History (11)

Changed August 10, 2012 09:36AM UTC by marianoguerra comment:1

same as the one I reported some seconds after :)

http://bugs.jqueryui.com/ticket/8485

maybe merge both with both examples

Changed August 10, 2012 12:46PM UTC by scottgonzalez comment:2

#8485 is a duplicate of this ticket.

Changed August 10, 2012 12:57PM UTC by scottgonzalez comment:3

#8486 is a duplicate of this ticket.

Changed August 10, 2012 01:29PM UTC by Scott González comment:4

resolution: → fixed
status: newclosed

Dialog: Don't use $.attrFn since it's empty in jQuery 1.8.0. Fixes #8484 - Text of buttons in dialog is not shown with jquery 1.8.0.

Changeset: 5e935ead9fbfb0ab368a9828a4d4b8d17eb38d5c

Changed August 10, 2012 01:30PM UTC by scottgonzalez comment:5

milestone: 1.9.01.8.23

In the meantime, you can either delete $.attrFn; or if ( $.attrFn ) { $.attrFn.text = true; }.

Changed August 11, 2012 03:45AM UTC by scottgonzalez comment:6

#8487 is a duplicate of this ticket.

Changed August 11, 2012 12:33PM UTC by scottgonzalez comment:7

#8488 is a duplicate of this ticket.

Changed August 11, 2012 12:33PM UTC by scottgonzalez comment:8

#8489 is a duplicate of this ticket.

Changed August 11, 2012 02:01PM UTC by staticdream comment:9

_comment0: don't forget you can use the code below after initializing the dialog in the interim! \ \ $("#confirm_dialog").parent().find("button[text='Ok']").find("span").html("Ok"); 1344693863822330

don't forget you can use the code below after initializing the dialog in the interim without having to modify the actual jquery script! :)

$("#confirm_dialog").parent().find("button[text='Ok']").find("span").html("Ok");

Changed August 13, 2012 02:29AM UTC by scottgonzalez comment:10

Replying to [comment:9 staticdream]:

don't forget you can use the code below...

As I mentioned above, a better fix is to just delete $.attrFn after loading jQuery.

Changed August 14, 2012 12:14PM UTC by scottgonzalez comment:11

#8496 is a duplicate of this ticket.