#8675 closed bug (fixed)

Opened October 15, 2012 01:16PM UTC

Closed October 23, 2012 06:50PM UTC

Dialog: Position with pixels in array doesn't work with back compat disabled

Reported by: Mamen Owned by:
Priority: blocker Milestone: 1.9.1
Component: ui.dialog Version: 1.9.0
Keywords: Cc:
Blocked by: Blocking:
Description
$("#dialog").dialog({position: [200, 200]});

This will render the same as [0, 0]. String values DO work. For example ['center', 'center']

Attachments (0)
Change History (8)

Changed October 15, 2012 02:35PM UTC by scottgonzalez comment:1

resolution: → worksforme
status: new → closed

Works for me: http://jsbin.com/udacal/1/edit

Changed October 15, 2012 04:45PM UTC by Mamen comment:2

It doesn't work at all here. However my inital statement was somewhat wrong. In IE, and Chrome it defaults to "center center" if numerics are used. In Opera it defaults to "center top".

Changed October 15, 2012 04:56PM UTC by Mamen comment:3

Hmm. I suspect this may be related to frames. The problem is most prominent with Opera. In all browsers I have tested, it works when selecting the live preview (stand alone page). May be problems with changing values live also.

Changed October 16, 2012 01:58PM UTC by scottgonzalez comment:4

I'm still not seeing any problems. The behavior you're seeing in Opera with the dialog showing at the top is caused by the fact that the document doesn't have enough height. Add another element to the page that actually makes the document taller and you'll see the positioning is working just fine.

Changed October 16, 2012 02:01PM UTC by Mamen comment:5

May be something like that. However it fill fail in all browsers if you add

<script>$.uiBackCompat = false;</script>

The reason is that dialog uses offset, which is depricated. The option [200,200] is however NOT marked as depricated.

Changed October 16, 2012 03:13PM UTC by scottgonzalez comment:6

milestone: 1.10.0 → 1.9.1
priority: minor → blocker
resolution: worksforme
status: closed → reopened
summary: dialog: position with pixels in array doesn't work → Dialog: Position with pixels in array doesn't work with back compat disabled

Changed October 16, 2012 03:14PM UTC by scottgonzalez comment:7

status: reopened → open

Changed October 23, 2012 06:50PM UTC by Scott González comment:8

resolution: → fixed
status: open → closed

Dialog: Don't use deprecated offset option for .position(). Fixes #8675 - Dialog: Position with pixels in array doesn't work with back compat disabled.

Changeset: 11effcbd35c7a0b36af2a710b385d741f5849cbf