Search and Top Navigation
#8687 closed bug (fixed)
Opened October 16, 2012 03:22PM UTC
Closed October 18, 2012 01:03AM UTC
Last modified October 18, 2012 01:04AM UTC
.jshintrc files not copied to dist
| Reported by: | southerd | Owned by: | mikesherov |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.1 |
| Component: | [meta] ui.build | Version: | 1.9.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
When building using grunt release, the .jshint files are not copied to the dist directory. This causes tests to fail when run against the build.
Attachments (0)
Change History (10)
Changed October 17, 2012 03:30PM UTC by comment:1
| owner: | → southerd |
|---|---|
| status: | new → pending |
Changed October 17, 2012 03:36PM UTC by comment:2
| status: | pending → open |
|---|
mikesherov: Our QUnit tests run JSHint and they pull in the .jshintrc file using ajax. Of course, you can disable the JSHint test with ?nojshint=true, but we should probably have the default settings for tests working.
Changed October 17, 2012 03:40PM UTC by comment:3
| owner: | southerd → mikesherov |
|---|---|
| status: | open → assigned |
Got it. That's certainly interesting. Seems the path to the file just needs one more ../
Pull request coming shortly
Changed October 17, 2012 03:47PM UTC by comment:4
That won't work- .jshint will then no longer work when run from the source directory (./test). The dist directory I referred to is dist/jquery-ui-<%= version %>/ which contains the concatenated and minified files. The underlying problem is that minimatch, the globbing library grunt uses, doesn't copy hidden . files in the 0.3.x grunt releases- Ben Alman will be fixing this in 0.4, but another solution might be needed now.
Changed October 17, 2012 03:52PM UTC by comment:5
Yup, you're right. I just wrapped my head around it. you're talking about the test suite in dist. Looking for a solution now.
Changed October 17, 2012 03:56PM UTC by comment:6
To save you a bit of time, I poked at it a bit during the Summit.
Changing the copy line from "ui/*" to "ui/{.,}*" does not seem to work.
Adding the line "ui/.jshintrc" puts the .jshint in the wrong location (in jquery-ui-{version}/ instead of jquery-ui-{version}/ui)
I regressed to hand-copying after a build- didn't have time to shave yaks at the summit :(
Changed October 17, 2012 04:35PM UTC by comment:7
Changed October 17, 2012 04:37PM UTC by comment:8
southerd, thanks for your help!
Changed October 18, 2012 01:03AM UTC by comment:9
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Build: Include ui/.jshintrc. Fixes #8687 - .jshintrc files not copied to dist.
Changeset: 390510c7059d98d68cfe082530051c476ee08be4
Changed October 18, 2012 01:04AM UTC by comment:10
| milestone: | 1.10.0 → 1.9.1 |
|---|
The .jshintrc files aren't really needed in the distributed files, so we only copied the one that's required for the QUnit tests.
Thanks for contributing! I'm not able to reproduce this issue. .jshintrc is not being copied to the dist directory, but how would this be causing the tests to fail? Can you be more specific in what you're doing when you say "run against the build"?