Search and Top Navigation
#8694 closed bug (fixed)
Opened October 17, 2012 12:45PM UTC
Closed October 21, 2012 07:55PM UTC
Accordion: 1.9 - active: null allows panels to be collapsible.
| Reported by: | martinkoutny | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.9.1 |
| Component: | ui.accordion | Version: | 1.9.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
In jQuery UI 1.8, when I initialize Accordion with option active: false it show Accordion with all collapsed panels. After open first panel, user can swith them, but can't close all of them back - one panel is still open.
In jQuery UI 1.9 with same options. It will show accordion with already opened first panel. At API documentation of active option is "This requires the collapsible option to be true.". But when I enable it, accordion starts fine (with all panels collapsed) but when user open one, he can also close it.
I found solution of this different behavior:
In 1.9 use option active: null to get same result like use active: false in 1.8.
Is this usage alright? Or it's a bug?
Attachments (0)
Change History (7)
Changed October 17, 2012 02:25PM UTC by comment:1
| summary: | 1.9 Accordion - active and collapsible options → 1.9 Accordion - active: null allows panels to be collapsible. |
|---|
Changed October 17, 2012 02:25PM UTC by comment:2
| status: | new → open |
|---|
Changed October 17, 2012 03:37PM UTC by comment:3
| summary: | 1.9 Accordion - active: null allows panels to be collapsible. → Accordion: 1.9 - active: null allows panels to be collapsible. |
|---|
Pull request to fix this active: null problem
Changed October 18, 2012 02:56PM UTC by comment:4
| resolution: | → fixed |
|---|---|
| status: | open → closed |
Accordion: handle active: null. Fixes #8694: 1.9 Accordion - active: null allows panels to be collapsible.
Changeset: c2802d7aa05e6dc7731806a35d9f0057405a22c7
Changed October 18, 2012 02:58PM UTC by comment:5
| milestone: | 1.10.0 → 1.9.1 |
|---|---|
| resolution: | fixed |
| status: | closed → reopened |
This actually broke back compat.
Changed October 21, 2012 12:25PM UTC by comment:6
Changed October 21, 2012 07:55PM UTC by comment:7
| resolution: | → fixed |
|---|---|
| status: | reopened → closed |
Fixed in eb392b30359e334a1777ed3a8bc1237ce09528a5.
active: null should not allow all panels to be collapsed. The only way to have collapsed panels is to use collapsible: true.