Skip to main content

Search and Top Navigation

#8696 closed bug (fixed)

Opened October 18, 2012 12:51PM UTC

Closed October 23, 2012 06:13PM UTC

Multiple collapsible Accordions won't work together

Reported by: dittodhole Owned by:
Priority: blocker Milestone: 1.9.1
Component: ui.accordion Version: 1.9.0
Keywords: regression Cc:
Blocked by: Blocking:
Description

Please see fiddle: http://jsfiddle.net/dittodhole/3j9r4/

Basically I have multiple collapsible Accordions on one page. If I open (click) one, it gets rendered "under" (z-index) the next Accordion.

Attachments (0)
Change History (5)

Changed October 18, 2012 01:07PM UTC by dittodhole comment:1

updated example fiddle to new h3-tags: http://jsfiddle.net/dittodhole/3j9r4/1/ (still not working as expected)

Changed October 18, 2012 01:09PM UTC by dittodhole comment:2

see example (http://jsfiddle.net/dittodhole/3j9r4/2/) for working example with 1.8.4

Changed October 18, 2012 02:38PM UTC by scottgonzalez comment:3

component: ui.coreui.accordion
keywords: → regression
milestone: 1.10.01.9.1
priority: minorblocker
status: newopen

An actually reduced test case: http://jsfiddle.net/3j9r4/3/

Changed October 21, 2012 08:24PM UTC by maciejmrozinski comment:4

even more reduced test case:

http://jsfiddle.net/3j9r4/4/

Two accordion it's not the case here. Accordion doesn't recalculate it's height after collapsing or expanding. When we expand it, the main accordion div have the same height as before expanding and this is resulting in not pushing text down. If we remove height style on main accordion div, all positioning becomes valid.

Do we need to set height property on the accordion? We didn't do that in 1.8 and i think it's not necessary for accordion to work well.

This is my pull request that resolves the problem by eliminating operations on accordion height property:

https://github.com/jquery/jquery-ui/pull/785

Changed October 23, 2012 06:13PM UTC by Maciej Mroziński comment:5

resolution: → fixed
status: openclosed

Accordion: Remove code that sets accordion height. Fixed #8696 - Multiple collapsible Accordions won't work together.

Changeset: f4b3cd527116b25d4d6f44c2df0f2c472b961e6a