Search and Top Navigation
#8848 closed bug (fixed)
Opened November 23, 2012 10:16AM UTC
Closed November 25, 2012 10:35PM UTC
Last modified November 25, 2012 10:55PM UTC
Build: release.js fails to require shelljs/global
| Reported by: | jzaefferer | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | git |
| Component: | [meta] ui.build | Version: | git (not yet released) |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
Trying to release 1.9.2. Running
node release.jsfails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353
Error: Cannot find module 'shelljs/global'
Its installed in
__release/node_modules. I guess it doesn't work because the dependency is installed inside the
__releasefolder, but require runs one level higher up.
Installing shelljs globally doesn't help either.
When doing the 1.9.1 release, I ended up with shelljs 0.0.8. I tried installing that version, didn't make a difference.
Attachments (0)
Change History (10)
Changed November 23, 2012 10:17AM UTC by comment:1
| description: | Trying to release 1.9.2. Running {{{node release.js}}} fails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353 \ \ {{{Error: Cannot find module 'shelljs/global'}}} \ \ Its installed in __release/node_modules. I guess it doesn't work because the dependency is installed inside the __release folder, but require runs one level higher up. → Trying to release 1.9.2. Running {{{node release.js}}} fails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353 \ \ {{{Error: Cannot find module 'shelljs/global'}}} \ \ Its installed in __release/node_modules. I guess it doesn't work because the dependency is installed inside the __release folder, but require runs one level higher up. \ \ Installing shelljs globally doesn't help either. |
|---|
Changed November 23, 2012 10:17AM UTC by comment:2
| status: | new → open |
|---|
Changed November 23, 2012 10:21AM UTC by comment:3
| description: | Trying to release 1.9.2. Running {{{node release.js}}} fails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353 \ \ {{{Error: Cannot find module 'shelljs/global'}}} \ \ Its installed in __release/node_modules. I guess it doesn't work because the dependency is installed inside the __release folder, but require runs one level higher up. \ \ Installing shelljs globally doesn't help either. → Trying to release 1.9.2. Running {{{node release.js}}} fails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353 \ \ {{{Error: Cannot find module 'shelljs/global'}}} \ \ Its installed in __release/node_modules. I guess it doesn't work because the dependency is installed inside the __release folder, but require runs one level higher up. \ \ Installing shelljs globally doesn't help either. \ \ When doing the 1.9.1 release, I ended up with shelljs 0.0.8. I tried installing that version, didn't make a difference. |
|---|
Changed November 23, 2012 01:55PM UTC by comment:4
Installing in the working directory helps. Just need to remove the cwd-argument to the npm-install exec call.
Changed November 23, 2012 02:13PM UTC by comment:5
While on it, update the Trac update instructions to mention timezone adjustment. Need to take Trac server time into account.
Changed November 25, 2012 10:26PM UTC by comment:6
| description: | Trying to release 1.9.2. Running {{{node release.js}}} fails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353 \ \ {{{Error: Cannot find module 'shelljs/global'}}} \ \ Its installed in __release/node_modules. I guess it doesn't work because the dependency is installed inside the __release folder, but require runs one level higher up. \ \ Installing shelljs globally doesn't help either. \ \ When doing the 1.9.1 release, I ended up with shelljs 0.0.8. I tried installing that version, didn't make a difference. → Trying to release 1.9.2. Running {{{node release.js}}} fails here: https://github.com/jquery/jquery-ui/blob/8def77cb5cfefb733874d15a2294f02fc5ae78ae/build/release/release.js#L353 \ \ {{{Error: Cannot find module 'shelljs/global'}}} \ \ Its installed in {{{__release/node_modules}}}. I guess it doesn't work because the dependency is installed inside the {{{__release}}} folder, but require runs one level higher up. \ \ Installing shelljs globally doesn't help either. \ \ When doing the 1.9.1 release, I ended up with shelljs 0.0.8. I tried installing that version, didn't make a difference. |
|---|
Changed November 25, 2012 10:35PM UTC by comment:7
| resolution: | → fixed |
|---|---|
| status: | open → closed |
Build: Install shell dependencies in the right direcytory. Update trac instructions to point out that only minutes and seconds need to be changed. Fixes #8848 - Build: release.js fails to require shelljs/global.
Changeset: 62ae078f1472b15cd6513eceeff2b9d270b94d46
Changed November 25, 2012 10:36PM UTC by comment:8
Build: Install shell dependencies in the right direcytory. Update trac instructions to point out that only minutes and seconds need to be changed. Fixes #8848 - Build: release.js fails to require shelljs/global.
(cherry picked from commit 62ae078f1472b15cd6513eceeff2b9d270b94d46)
Changeset: f919657923f822b891d661fb216884c587e5759b
Changed November 25, 2012 10:37PM UTC by comment:9
| version: | 1.9.1 → git |
|---|
Changing version to git as there's no need for this in the changelog.
Changed November 25, 2012 10:55PM UTC by comment:10
| milestone: | 1.10.0 → git |
|---|
It's the milestone, not the version, that matters for the changelog :-)