#8975 closed bug (fixed)

Opened January 17, 2013 10:54AM UTC

Closed April 01, 2014 06:44PM UTC

Buttonset: refresh method causes JS error after adding new radio buttons

Reported by: gvas Owned by: tj.vantoll
Priority: minor Milestone: 1.11.0
Component: ui.button Version: 1.9.2
Keywords: Cc:
Blocked by: Blocking:
Description

Adding a new radio button to a buttonset and invoking the buttonset's refresh method causes a JS exception. In contrast, adding new checkboxes works fine.

Tested in: Chrome 24, IE 7, IE 8

Operating system: Windows 7 Ultimate x64

Steps to reproduce:

1. Initialize a buttonset

2. Insert a new radio button below the buttonset

3. Invoke the buttonset's refresh method

Expected:

The new radio button is added to the buttonset

Actual:

JS exception: "cannot call methods on button prior to initialization; attempted to call method 'widget'"

Demo: http://jsfiddle.net/zQKV2/

Attachments (0)
Change History (4)

Changed January 17, 2013 01:23PM UTC by tj.vantoll comment:1

milestone: none → 1.11.0
owner: → tj.vantoll
status: new → assigned
summary: buttonset('refresh') causes exception after adding new radio buttons → Buttonset: refresh method causes JS error after adding new radio buttons

Verified on master - http://jsfiddle.net/tj_vantoll/zQKV2/1/. I'll take a look at this one.

Changed January 20, 2013 03:50AM UTC by tj.vantoll comment:2

Pull request https://github.com/jquery/jquery-ui/pull/888.

Changed March 08, 2013 02:46AM UTC by tj.vantoll comment:3

Closed the pull request because this will have to be handled another way. The pull does have a failing test for this problem: https://github.com/jquery/jquery-ui/pull/888/files.

Changed April 01, 2014 06:44PM UTC by Scott González comment:4

resolution: → fixed
status: assigned → closed

Button: Properly refresh button sets with new radio buttons

Fixes #8975

Ref gh-888

Changeset: 0059722b6b43c4985dbbd5f1494524442c12ddb0