#9317 closed bug (fixed)

Opened May 21, 2013 12:04PM UTC

Closed May 22, 2013 06:00PM UTC

Last modified November 26, 2013 03:35PM UTC

Tabs: Incorrect remote tab detection in IE7

Reported by: roeycohen@gmail.com Owned by: roeycohen@gmail.com
Priority: minor Milestone: 1.10.4
Component: ui.tabs Version: 1.10.3
Keywords: Cc:
Blocked by: Blocking:
Description

Hi,

there is a problem with the TABs widget under IE7.

adding a new tab using java-script and calling refresh doesn't work properly.

the problem is that "anchor.href" under ie7 does not return the full URL, only what is written inside the href attribute.

this causes isLocal(line 26 at the source code) to fail and always return false even if i want a new local tab.

please let me know if you need more data,

Roey

Attachments (0)
Change History (9)

Changed May 21, 2013 12:41PM UTC by scottgonzalez comment:1

owner: → roeycohen@gmail.com
status: new → pending

Can you please provide a reduced test case showing the problem? You can use http://jsfiddle.net/tj_vantoll/ZjgbK/ as a starting point.

Changed May 21, 2013 01:34PM UTC by roeycohen@gmail.com comment:2

status: pending → new

ok, i've upload a working sample:

http://jsfiddle.net/ZjgbK/20/

running chrome, ie >= 8 works fine.

switching to ie7 mode doesn't work (the 2nd alert does not contain the whole url, causing the widget's isLocal to think that the dynamically added tab is not local. also the new div container is always visible because the plugin doesn't even look for it.

help :)

Roey

Changed May 21, 2013 03:01PM UTC by roeycohen@gmail.com comment:3

please notice that this is not a duplicate of http://bugs.jqueryui.com/ticket/7822 (i'm not using the base tag).

though the solution may be giving us the programmers the option to tell the widget whether the tab is local or not.

thanks,

Roey

Changed May 22, 2013 12:21AM UTC by tj.vantoll comment:4

resolution: → notabug
status: new → closed

You're running into this IE <= 7 quirk http://stackoverflow.com/questions/1593174/wrong-extraction-of-attrhref-in-ie7-vs-all-other-browsers.

Pass the 

href
attribute embedded in the HTML string (
$( "<a href='#dynamic'></a>")
instead of 
$( "a", { href: "#dynamic" } )
and this will work fine: http://jsfiddle.net/tj_vantoll/PGfNT/

Changed May 22, 2013 01:28AM UTC by scottgonzalez comment:5

resolution: notabug
status: closed → reopened

I wouldn't say that this isn't a bug. It might be a won't fix though.

Changed May 22, 2013 05:59PM UTC by scottgonzalez comment:6

milestone: none → 1.11.0
status: reopened → open
summary: ui tabs - isLocal function IE7 bug → Tabs: Incorrect remote tab detection in IE7

Changed May 22, 2013 06:00PM UTC by Scott González comment:7

resolution: → fixed
status: open → closed

Tabs: Restore anchor cloning for remote tab testing. Fixes #9317 - Tabs: Incorrect remote tab detection in IE7.

Changeset: daf3f0d9af5b29dc090e15d57cf884e3c12f7cad

Changed November 26, 2013 03:34PM UTC by Scott González comment:8

Tabs: Restore anchor cloning for remote tab testing. Fixes #9317 - Tabs: Incorrect remote tab detection in IE7.

(cherry picked from commit daf3f0d9af5b29dc090e15d57cf884e3c12f7cad)

Changeset: 39ff5b36e4ed2513f7dc11c22ea4df5d03f9f7b7

Changed November 26, 2013 03:35PM UTC by scottgonzalez comment:9

milestone: 1.11.0 → 1.10.4