Search and Top Navigation
#9532 closed bug (fixed)
Opened September 04, 2013 07:04PM UTC
Closed October 19, 2013 03:15AM UTC
Last modified April 24, 2014 07:39PM UTC
Need a way in Menu to keep ui-state-active class on selected item
| Reported by: | fnagel | Owned by: | k_borchers |
|---|---|---|---|
| Priority: | minor | Milestone: | git |
| Component: | ui.menu | Version: | git (not yet released) |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
When Selectmenu is opened we have a ui-state-focus class on the active item. This is correct as the menu item has focus but we need to add ui-state-active as well.
Without, the item is could not have its own style and looks almost similar to the button in the default CSS framework style.
I've tried to simply add the class when the menu is opened (as we did for for removing old *-focus classes) but its removed after delay in _close method.
Any idea how to workaround?
This ticket is related to the comments of Juan Lanus, see:
http://wiki.jqueryui.com/w/page/12138056/Selectmenu
I've already talked to Scott via IRC and we decided to open a ticket for Menu.
Attachments (0)
Change History (5)
Changed September 17, 2013 04:40AM UTC by comment:1
| owner: | → k_borchers |
|---|---|
| status: | new → assigned |
Changed September 17, 2013 09:31PM UTC by comment:2
@k_borchers, please see this branch: https://github.com/fnagel/jquery-ui/tree/new-selectmenu-dev
Just open a selectmenu and watch the ui-state-active class disappear after 1/3 second. The branch includes a unit test.
Changed October 19, 2013 03:15AM UTC by comment:3
| resolution: | → fixed |
|---|---|
| status: | assigned → closed |
Menu: More precise removal of ui-state-active class for easier CSS overrides. Fixes #9532 - Need a way in Menu to keep ui-state-active class on selected item
Changeset: 52307ebadbca3f403549140e1d34f08bc07bf8ce
Changed October 20, 2013 02:37AM UTC by comment:4
| milestone: | none → 1.11.0 |
|---|
Changed April 24, 2014 07:39PM UTC by comment:5
| milestone: | 1.11.0 → git |
|---|---|
| version: | 1.10.3 → git |
@fnagel, do you have, or could you create, a branch where you are adding ui-state-active but it's being removed. I have some things I can try here but would be easier to test if you have selectmenu doing what you want and demonstrating the issue with menu.