#9547 closed bug (fixed)

Opened September 10, 2013 06:33PM UTC

Closed October 19, 2013 03:13AM UTC

Last modified January 31, 2014 10:52PM UTC

Resizable: off-by-one pixel dimensions with helper and grid

Reported by: wch Owned by: wch
Priority: minor Milestone: 1.10.4
Component: ui.resizable Version: 1.10.0
Keywords: regression Cc:
Blocked by: Blocking:
Description

This happens with 1.10.3: http://jsfiddle.net/winstonchang/nCAkM/

But not with 1.9.2: http://jsfiddle.net/winstonchang/dfqtt/

This happens when a helper is used; if it's not used, then the problem doesn't happen.

Attachments (0)
Change History (13)

Changed September 11, 2013 02:27PM UTC by tj.vantoll comment:1

owner: → wch
status: new → pending

Hi wch,

Thanks for taking the time to contribute to the jQuery UI project. I'm not seeing the problem you're describing. I altered your test case to output the height and width of the element and it appears to be working correctly: http://jsfiddle.net/tj_vantoll/czkeF/.

Maybe I'm just missing something. Could you please alter my test case to show the issue you're seeing?

Changed September 11, 2013 02:28PM UTC by tj.vantoll comment:2

Also if you are seeing the issue in my test case us know what browser you're seeing it in. Thanks.

Changed September 18, 2013 08:14PM UTC by wch comment:3

status: pending → new

Hi - I am able to reproduce it with your example. The trick is to click on the corner, move the mouse until the frame shows up (but don't actually change to a different size) and then let go of the button. That's when it happens. This occurs for me in Chrome and Firefox.

Also, in your example, the displayed values for Height and Weight don't change, even though the box shrinks each time.

Changed September 18, 2013 08:15PM UTC by hadley comment:4

_comment0: Possibly related, if you make the border very thick (as in http://bugs.jqueryui.com/ticket/9547), it doesn't line up with the resulting box size. → 1379535385744732

Possibly related, if you make the border very thick (as in http://jsfiddle.net/hyGBh/), it doesn't line up with the resulting box size.

Changed September 23, 2013 07:58PM UTC by tj.vantoll comment:5

keywords: → regression
status: new → open
summary: resizable results in off-by-one pixel dimensions when helper is used → Resizable: off-by-one pixel dimensions with helper and grid
version: 1.10.3 → 1.10.0

The behavior starts in 1.10.0 so I'm guessing this is a regression caused by https://github.com/jquery/jquery-ui/commit/6e0a0553ce85997e4f37597800b440b1e4371b5b. I haven't confirmed that though.

Changed October 16, 2013 02:43AM UTC by k_borchers comment:6

https://github.com/jquery/jquery-ui/pull/1107

Changed October 19, 2013 03:13AM UTC by Kris Borchers comment:7

resolution: → fixed
status: open → closed

Resizable: Store size based on calculated helper size to prevent 1 pixel shifts. Fixes #9547 - Resizable: off-by-one pixel dimensions with helper and grid

Changeset: 14065dc23bb453b6c30138f225c9db728dd7e455

Changed November 19, 2013 12:58PM UTC by tj.vantoll comment:8

#9667 is a duplicate of this ticket.

Changed November 26, 2013 08:54PM UTC by Kris Borchers comment:9

Resizable: Store size based on calculated helper size to prevent 1 pixel shifts. Fixes #9547 - Resizable: off-by-one pixel dimensions with helper and grid

(cherry picked from commit 14065dc23bb453b6c30138f225c9db728dd7e455)

Changeset: e29e5b56afea5a0250636d9c9fd97106732bfe84

Changed November 26, 2013 08:56PM UTC by scottgonzalez comment:10

milestone: none → 1.10.4

Changed January 31, 2014 02:34PM UTC by zvesp comment:11

Is this supposed to be fixed in 1.10.4? I'm observing behaviour like that described http://jsfiddle.net/9x5Zt

and http://jqueryui.com/resizable/#helper

Changed January 31, 2014 02:39PM UTC by scottgonzalez comment:12

That demos doesn't even use a grid. If you're experiencing this problem, please provide a new test case showing the problem.

Changed January 31, 2014 10:52PM UTC by zvesp comment:13

http://jsfiddle.net/9x5Zt/1/

The same behaviour occurs in helper, in the demos, which is why I linked to it. -- Having glanced at the source code I saw ghost and helper were related, so thought this might be relevent. Apologies if it was unnecessarily off-topic, and deserving of a separate ticket.