Skip to main content

Search and Top Navigation

#9671 closed bug (fixed)

Opened November 20, 2013 11:10AM UTC

Closed August 24, 2014 11:21AM UTC

Last modified August 24, 2014 11:21AM UTC

Draggable: iframeFix doesn't handle iframes that move

Reported by: fejesjoco Owned by: mikesherov
Priority: minor Milestone: 1.11.2
Component: ui.draggable Version: 1.10.3
Keywords: Cc:
Blocked by: Blocking:
Description

I created a very basic fiddle here: http://jsfiddle.net/5w34F/ (it uses an older version of jquery-ui, but it's the same as in 1.10.3).

When you are dragging, and do a sudden mouse movement, if the mouse pointer ends up inside the iframe, the dragging is suspended. AFAIK iframeFix should fix exactly that, but it doesn't.

I changed jquery-ui source code so that the iframeFix div's opacity is 1 (instead of 0.001) and it's color is yellow (instead of white). You can clearly see that the yellow fixer div remains at its initial position and doesn't move along with the iframe. Moreover, if I add a stack: "div" option, the fixer div's z-index will be too low and it will be behind the iframe.

Attachments (0)
Change History (7)

Changed November 20, 2013 12:22PM UTC by scottgonzalez comment:1

status: newopen
summary: draggable iframefix doesn't workDraggable: iframeFix doesn't handle iframes that move

We should copy the new implementation from the interactions branch.

Changed November 20, 2013 12:32PM UTC by fejesjoco comment:2

About the title change: the iframe doesn't actually move in itself, it moves only because of the dragging, but in this respect, all iframes move.

Changed November 20, 2013 12:35PM UTC by scottgonzalez comment:3

That's not true that all iframes move. Most iframes don't move relative to the top left corner of the document. This one does.

Changed November 20, 2013 12:45PM UTC by fejesjoco comment:4

Sorry, you're right, I thought iframeFix is supposed to handle iframes inside the draggable area, now I see this rather applies to iframes outside of it. In this case I guess it's rather a feature request, but I'm very happy to hear that a new branch supports both cases.

Changed November 20, 2013 05:13PM UTC by scottgonzalez comment:5

owner: → mikesherov
status: openassigned

Changed August 24, 2014 11:21AM UTC by Mike Sherov comment:6

resolution: → fixed
status: assignedclosed

Draggable: append divs to iframe parent for iframefix

This allows the blocking div to move with the iframe in

most situations, whereas appending to the body wouldn't.

Fixes #9671

Changeset: c7bec85cfa7711bb2612278eb980d0d14dade3b9

Changed August 24, 2014 11:21AM UTC by mikesherov comment:7

milestone: none1.11.2