#10072 closed bug (fixed)
Dialog test fails with jQuery 1.6 on "TypeError: undefined off() is not a function"
Reported by: | Krinkle | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.11.0 |
Component: | ui.dialog | Version: | git (not yet released) |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
Dialog tests fail unconditionally in all browsers with jQuery 1.6.
TestSwarm:
- Job: http://swarm.jquery.org/job/3061
- Results in Chrome 34: http://swarm.jquery.org/result/1869192
Test 10. dialog: core: #7960: resizable handles below modal overlays (2, 1, 3) 23 ms
Resizable handles have lower z-index than modal overlay Died on test #2 at /tests/unit/dialog/dialog_core.js:128:1 at /tests/unit/dialog/dialog_core.js:231:3: undefined is not a function Source: TypeError: undefined is not a function at $.widget._destroyOverlay (/ui/dialog.js:846:7) at null._destroyOverlay (/ui/widget.js:108:25) at $.widget._destroy (/ui/dialog.js:153:8) at null._destroy (/ui/widget.js:108:25) at $.Widget.destroy (/ui/widget.js:286:8) at HTMLDivElement.<anonymous> (/ui/widget.js:206:39) at Function.jQuery.extend.each (/tests/jquery-1.6.js:641:20) at jQuery.fn.jQuery.each (/tests/jquery-1.6.js:265:17) at $.fn.(anonymous function) [as dialog] (/ui/widget.js:192:9) at Object.<anonymous> (/tests/unit/dialog/dialog_core.js:137:9) Expected 1 assertions, but 2 were run Source: at /tests/unit/dialog/dialog_core.js:128:1 at /tests/unit/dialog/dialog_core.js:231:3
Change History (2)
comment:1 Changed 9 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:2 Changed 9 years ago by
Milestone: | none → 1.11.0 |
---|
Note: See
TracTickets for help on using
tickets.
Dialog: Fix off() -> unbind() for jQuery 1.6 compat
Follows-up c9815f13b487d027ef9b.
Fixes #10072 Closes gh-1256