Progressbar: base CSS refers to image that's missing in themeless builds
|Reported by:||usmonster||Owned by:|
The CSS for the Progressbar widget in jQuery UI 1.10/1.11 contains a reference to "images/animated-overlay.gif", which is not included in custom jQuery UI builds with "no theme" selected. Even though users are expected to override a number of properties if they select no theme, users ideally expect the base CSS files provided to be self-contained and to not cause any 404s. The image probably should be included, either in the built zip (in which case please change the component to "[meta] ui.build") or as a data URI in the Progressbar CSS. Thoughts?
This pull request replaces the reference with a data URI:
My only concern with this approach is that it makes the CSS bigger, and I don't know if you have target sizes for different assets, or other guidelines or metrics that this change might violate. (Also note that jQuery 1.10 still supported IE 7, which doesn't support data URIs, so this approach would not be applicable to that version.)
scott.gonzalez recommended on IRC that I file this bug report for more discussion with the team:
Thanks for any feedback.
Change History (5)
comment:4 Changed 3 years ago by Usman Akeju
- Resolution set to fixed
- Status changed from new to closed