#10134 closed bug (fixed)
Progressbar: base CSS refers to image that's missing in themeless builds
| Reported by: | usmonster | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.11.1 |
| Component: | ui.progressbar | Version: | 1.11.0 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The CSS for the Progressbar widget in jQuery UI 1.10/1.11 contains a reference to "images/animated-overlay.gif", which is not included in custom jQuery UI builds with "no theme" selected. Even though users are expected to override a number of properties if they select no theme, users ideally expect the base CSS files provided to be self-contained and to not cause any 404s. The image probably should be included, either in the built zip (in which case please change the component to "[meta] ui.build") or as a data URI in the Progressbar CSS. Thoughts?
This pull request replaces the reference with a data URI:
https://github.com/jquery/jquery-ui/pull/1276
My only concern with this approach is that it makes the CSS bigger, and I don't know if you have target sizes for different assets, or other guidelines or metrics that this change might violate. (Also note that jQuery 1.10 still supported IE 7, which doesn't support data URIs, so this approach would not be applicable to that version.)
scott.gonzalez recommended on IRC that I file this bug report for more discussion with the team:
http://irc.jquery.org/%23jqueryui-dev/default_%23jqueryui-dev_20140702.log.html#t03:35:34
Thanks for any feedback.
Change History (5)
comment:1 Changed 9 years ago by
comment:2 Changed 9 years ago by
The gif is 1.7k, with the progressbar.css itself 619 bytes. That's not a terrible increase. If we ever need to use that image elsewhere, we can still figure out something better.
So yeah, sounds good to me.
comment:3 Changed 9 years ago by
Cool, I made the pull request here: https://github.com/jquery/jquery-ui/pull/1276 .
comment:4 Changed 9 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Progressbar: replace image reference in base CSS with data URI
The CSS for the Progressbar widget contained a reference to "images/animated-overlay.gif", which is not included in custom jQuery UI builds with "no theme" selected. This replaces the reference with a data URI.
Fixes #10134 Closes gh-1276
Changeset: e91f38ef1ede2a6191e718c6628fd7c34cfe5103
comment:5 Changed 9 years ago by
| Milestone: | none → 1.11.1 |
|---|
I'm for this. IMO the increased file size is worth it to remove an HTTP request, and this will be for 1.11, which doesn't support IE7.