#10668 closed bug (fixed)
DatePicker: instActive not released on instance destroy
| Reported by: | eshcharc | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.11.3 |
| Component: | ui.datepicker | Version: | 1.11.1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
In the days of client side frameworks and SPAs, considerations need to be made regarding client side page switch and optimizations and cleaning of assets.
When we examined and profiled our SPA on a page switch scenario, we've noticed that a jQuery-UI plugin is holding a whole element tree. A further examination led us to a date-picker component and the "global" "instActive".
It seems that when a datePicker instance is being destryed via _destroyDatePicker, "instActive" which is linked to this instance, is not taken care of and keep a reference to this instance and all of its tree elements. When a client side framework is involved, that makes it worse.
That can quite easily be treated.
Change History (6)
comment:1 Changed 8 years ago by
comment:2 Changed 8 years ago by
| Component: | ui.core → ui.datepicker |
|---|---|
| Status: | new → open |
comment:3 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
DatePicker: datepicker_instActive released on instance destroy
Fixes #10668 Closes gh-1362
Changeset: e5e3ca4240fbae9684f689ec6e00882ec0211922
comment:4 Changed 8 years ago by
| Milestone: | none → 1.12.0 |
|---|
comment:5 Changed 8 years ago by
DatePicker: datepicker_instActive released on instance destroy
Fixes #10668 Closes gh-1362 (cherry picked from commit e5e3ca4240fbae9684f689ec6e00882ec0211922)
Changeset: 47ceff8dbd1f64c081f8fd136d86a5db23fef0ff
comment:6 Changed 8 years ago by
| Milestone: | 1.12.0 → 1.11.3 |
|---|
UPDATE: correct name of global is "datepicker_instActive"