#10668 closed bug (fixed)

Opened October 19, 2014 06:27AM UTC

Closed October 20, 2014 01:18PM UTC

Last modified February 05, 2015 02:19PM UTC

DatePicker: instActive not released on instance destroy

Reported by:	eshcharc	Owned by:
Priority:	minor	Milestone:	1.11.3
Component:	ui.datepicker	Version:	1.11.1
Keywords:		Cc:
Blocked by:		Blocking:

Description

In the days of client side frameworks and SPAs, considerations need to be made regarding client side page switch and optimizations and cleaning of assets.

When we examined and profiled our SPA on a page switch scenario, we've noticed that a jQuery-UI plugin is holding a whole element tree. A further examination led us to a date-picker component and the "global" "instActive".

It seems that when a datePicker instance is being destryed via _destroyDatePicker, "instActive" which is linked to this instance, is not taken care of and keep a reference to this instance and all of its tree elements. When a client side framework is involved, that makes it worse.

That can quite easily be treated.

Attachments (0)

Change History (6)

Changed October 19, 2014 06:31AM UTC by eshcharc comment:1

UPDATE:

correct name of global is "datepicker_instActive"

Changed October 20, 2014 01:00PM UTC by tj.vantoll comment:2

component:	ui.core → ui.datepicker
status:	new → open

PR: https://github.com/jquery/jquery-ui/pull/1362

Changed October 20, 2014 01:18PM UTC by Chen Eshchar comment:3

resolution:	→ fixed
status:	open → closed

DatePicker: datepicker_instActive released on instance destroy

Fixes #10668

Closes gh-1362

Changeset: e5e3ca4240fbae9684f689ec6e00882ec0211922

Changed October 20, 2014 01:21PM UTC by scottgonzalez comment:4

milestone:	none → 1.12.0

Changed February 05, 2015 02:17PM UTC by Chen Eshchar comment:5