AMD loading broken on minified scripts

[sephii]

Using requirejs and trying to use jquery ui plugins from the minified/ directory raises a "Error: Script error for: jquery-ui/core". This is because minified scripts depend on "./core" instead of "./core.min".

This occurs in version 1.11.2, installed with Bower.

[Scott González]

You're probably looking for ​https://github.com/components/jqueryui/issues/new since we don't host minified files.

[sephii]

After reporting it to the maintainers of the components organization, it looks like this is indeed a bug on the jQuery UI side. It's apparently caused by the minify task from the Gruntfile that doesn't rewrite the dependencies after renaming the files. See ​https://github.com/components/jqueryui/issues/42 for more info.

Could you please reopen this issue?

[Scott González]

Before reopening this, I'd like to confirm that we want to keep this task. If we do keep it, we should probably just stop renaming the files. There definitely shouldn't be a "core.min" dependency, it should just be "core".

[Jörn Zaefferer]

sephii, what's the motivation for loading minified files using AMD? Seems like you should be loading non-minified files, then use the optimizer to create one or more optimized, minified files for production.

[Scott González]

We're going to remove the wrappers in the minified files. As Jörn has said, you should be doing the minification yourself using the optimizer.

[Alexander Schmitz]

The way we handle this in jQuery mobile is by parsing them out using comments read by the build script ​https://github.com/jquery/jquery-mobile/blob/master/js/core.js#L1-L2 ​https://github.com/jquery/jquery-mobile/blob/master/Gruntfile.js#L380

[rxaviers]

arschmitz correct me if I'm wrong. But, jQuery mobile doesn't handle this at all. Its final bundles (both the normal and the minified) include the generated-on-build-time UMD wrapper. It happens that, similarly to jQuery UI, the only bundle's dependency is jquery.

Anyway, the jquery dependency is safe from this minified problem. Because, jQuery is one of the few exceptions on AMD that defines itself as a named module. So, if one loads jquery.min.js, this code will be defined as a jquery AMD module.

[rxaviers]

On jQuery UI, we are distributing different things depending of the "channel":

• via download builder, we're distributing the bundles (JS and CSS) as defined by ​https://github.com/jquery/download.jqueryui.com/pull/214 and ​https://github.com/jquery/download.jqueryui.com/issues/207.
• via grunt task (via dist/), we're distributing the JS bundles only (no CSS) plus the minified JS components, but no images.

Questions to ourselves:

1. Should the dist/ folder of our repo be considered, as it sounds like, a distribution "channel"?
2. Which files should it include? The same ones of our download package?

[Scott González]

PR: ​https://github.com/jquery/jquery-ui/pull/1466

[Scott González]

Build: Don't use .min.js extension for individual source files

We don't actually use these files for anything other than size comparisons, but having the .min.js extension means that AMD is broken.

Note: If you're using AMD with the minified files, just run a build instead.

Fixes #10674 Closes gh-1466

Changeset: 47a32fb5b3c190123937e0178900ef754c3e220d