Opened 2 years ago

Closed 22 months ago

#11097 closed feature (fixed)

Spinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points

Reported by: arschmitz Owned by:
Priority: blocker Milestone: 1.12.0
Component: ui.spinner Version: 1.11.2
Keywords: Cc:
Blocked by: Blocking:

Description

With the new classes option this don't make a lot of sense any more. We should just remove them. One related question brought up by Jörn, was if this should really be an anchor, or should we switch to a button?

Change History (3)

comment:1 Changed 2 years ago by scottgonzalez

  • Milestone changed from none to 1.12.0
  • Priority changed from minor to blocker
  • Status changed from new to open
  • Summary changed from Spinner: remove _buttonHtml and _uiSpinnerHtml extension points to Spinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points
  • Type changed from bug to feature

Changing the ticket since we always have to go through deprecation first.

comment:2 Changed 2 years ago by jzaefferer

We're switching datepicker to buttons. Will probably need the same fiddling with CSS to deal with Firefox, but otherwise I see no reason against that.

comment:3 Changed 22 months ago by Alexander Schmitz

  • Resolution set to fixed
  • Status changed from open to closed

Spinner: Deprecate _uiSpinnerHtml and _buttonHtml extension points

Fixes #11097 Closes gh-1560

Changeset: d4719bf6160a0c99273abddc42e39a734e9943a2

Note: See TracTickets for help on using tickets.