Opened 3 years ago

Closed 2 years ago

#11097 closed feature (fixed)

Spinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points

Reported by: Alexander Schmitz Owned by:
Priority: blocker Milestone: 1.12.0
Component: ui.spinner Version: 1.11.2
Keywords: Cc:
Blocked by: Blocking:

Description

With the new classes option this don't make a lot of sense any more. We should just remove them. One related question brought up by Jörn, was if this should really be an anchor, or should we switch to a button?

Change History (3)

comment:1 Changed 3 years ago by Scott González

Milestone: none1.12.0
Priority: minorblocker
Status: newopen
Summary: Spinner: remove _buttonHtml and _uiSpinnerHtml extension pointsSpinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points
Type: bugfeature

Changing the ticket since we always have to go through deprecation first.

comment:2 Changed 3 years ago by Jörn Zaefferer

We're switching datepicker to buttons. Will probably need the same fiddling with CSS to deal with Firefox, but otherwise I see no reason against that.

comment:3 Changed 2 years ago by Alexander Schmitz

Resolution: fixed
Status: openclosed

Spinner: Deprecate _uiSpinnerHtml and _buttonHtml extension points

Fixes #11097 Closes gh-1560

Changeset: d4719bf6160a0c99273abddc42e39a734e9943a2

Note: See TracTickets for help on using tickets.