Opened 8 years ago
Closed 8 years ago
#11097 closed feature (fixed)
Spinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points
| Reported by: | Alexander Schmitz | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.12.0 |
| Component: | ui.spinner | Version: | 1.11.2 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
With the new classes option this don't make a lot of sense any more. We should just remove them. One related question brought up by Jörn, was if this should really be an anchor, or should we switch to a button?
Change History (3)
comment:1 Changed 8 years ago by
| Milestone: | none → 1.12.0 |
|---|---|
| Priority: | minor → blocker |
| Status: | new → open |
| Summary: | Spinner: remove _buttonHtml and _uiSpinnerHtml extension points → Spinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points |
| Type: | bug → feature |
comment:2 Changed 8 years ago by
We're switching datepicker to buttons. Will probably need the same fiddling with CSS to deal with Firefox, but otherwise I see no reason against that.
comment:3 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | open → closed |
Spinner: Deprecate _uiSpinnerHtml and _buttonHtml extension points
Fixes #11097 Closes gh-1560
Changeset: d4719bf6160a0c99273abddc42e39a734e9943a2
Note: See
TracTickets for help on using
tickets.
Changing the ticket since we always have to go through deprecation first.