Skip to main content

Search and Top Navigation

#11097 closed feature (fixed)

Opened February 12, 2015 04:33PM UTC

Closed June 18, 2015 12:30PM UTC

Spinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points

Reported by: arschmitz Owned by:
Priority: blocker Milestone: 1.12.0
Component: ui.spinner Version: 1.11.2
Keywords: Cc:
Blocked by: Blocking:

With the new classes option this don't make a lot of sense any more. We should just remove them. One related question brought up by Jörn, was if this should really be an anchor, or should we switch to a button?

Attachments (0)
Change History (3)

Changed February 12, 2015 04:40PM UTC by scottgonzalez comment:1

milestone: none1.12.0
priority: minorblocker
status: newopen
summary: Spinner: remove _buttonHtml and _uiSpinnerHtml extension pointsSpinner: Deprecate _buttonHtml() and _uiSpinnerHtml() extension points
type: bugfeature

Changing the ticket since we always have to go through deprecation first.

Changed February 12, 2015 04:50PM UTC by jzaefferer comment:2

We're switching datepicker to buttons. Will probably need the same fiddling with CSS to deal with Firefox, but otherwise I see no reason against that.

Changed June 18, 2015 12:30PM UTC by Alexander Schmitz comment:3

resolution: → fixed
status: openclosed

Spinner: Deprecate _uiSpinnerHtml and _buttonHtml extension points

Fixes #11097

Closes gh-1560

Changeset: d4719bf6160a0c99273abddc42e39a734e9943a2