Opened 13 years ago

Closed 13 years ago

Last modified 12 years ago

#1990 closed bug (duplicate)

Can not have multiple dialogs in latest version of UI

Reported by: rbrackett Owned by: rdworth
Priority: major Milestone:
Component: ui.core Version: 1.2.1
Keywords: dialog Cc:
Blocked by: Blocking:

Description

In fixing Ticket #1684, the ability to have multiple dialogs was lost. They 'new' keyword is no longer being used to create dialog objects and thus all dialogs are sharing the same data. As an example, if I create two dialogs, dialog1 and dialog2, and then call dialog1.dialogOpen();, dialog2 gets opened. This is an easy fix: just add the 'new' keyword to line 12 of ui.dialog.js.

I've included a patch for convenience.

Attachments (1)

multipleDialogsPatch.diff (391 bytes) - added by rbrackett 13 years ago.
Fix to let multiple dialogs work again in UI

Download all attachments as: .zip

Change History (5)

Changed 13 years ago by rbrackett

Attachment: multipleDialogsPatch.diff added

Fix to let multiple dialogs work again in UI

comment:1 Changed 13 years ago by paul

Owner: set to rworth

comment:2 Changed 13 years ago by Xichekolas

Just want to comment that I made this change and it definitely fixed the multiple dialog closing issue I was having. Thanks rbrackett!

comment:3 Changed 13 years ago by rdworth

Resolution: duplicate
Status: newclosed

Fixed by #2008 in rev4075

comment:4 Changed 12 years ago by (none)

Milestone: 1.2.2

Milestone 1.2.2 deleted

Note: See TracTickets for help on using tickets.