Tabbing stops in modal dialog

[Jacob]

If you launch a modal dialog and try to use the tab key to select elements in your browser the tabbing will halt on an arbitrary element (in this case, the jQuery UI logo in the top left).

The expected behaviour for a modal dialog would be to be "greedy" for keyboard accessbility and force the tabbing to cycle within the dialog alone.

This is reproducable locally and in the demo page ( ​http://ui.jquery.com/functional_demos/#ui.dialog with modal dialog selected)

[Scott González]

Possible solution:

var $first = $('.ui-dialog :tabbable:first');
var $last = $('.ui-dialog :tabbable:last');
$last.keypress(function(e) {
    if (e.keyCode == $.keyCode.TAB) {
        setTimeout(function() { $first.focus(); }, 1);
    }
});

Using keypress without the timeout will cause the focus to go to the second element (focus will be given to the first element before the default action of the keypress completes).

Using keyup will make it impossible to tab to the last element because the keyup of the tab from the previous element will be triggered immediately after the last element is given focus.

[Scott González]

This must also handle reverse order tabbing.

[Scott González]

Fixed in [662].

[Corey Frang]

Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog

Changeset: 96e5c241e1b26224c53738b590e07290db7a3e54

[Corey Frang]

Dialog: Tabbing out of a modal dialog was possible because keypress doesn't fire for tabs everywhere, switched to keyup. Added Unit Test - Caught by @DomenicDenicola - Fixes #3123 - Tabbing stops in modal dialog (cherry picked from commit 96e5c241e1b26224c53738b590e07290db7a3e54)

Changeset: 8f16cc304a97c7c3c2b5ab69678d666ec9ebd75a

[millman]

This issues still exists in IE 9. While tabbing within a dialog the tab falls out of the dialog.

[Scott González]

This works in master.