UI Accordion autoHeight:false animation jumps in 1.6rc6

[grabanski]

When you set the autoHeight to false then the animation jumps instead of being smooth. This worked fine in 1.6rc4 and happened when upgrading to 1.6rc6.

[Jörn Zaefferer]

Demo in SVN: ​http://jquery-ui.googlecode.com/svn/trunk/demos/accordion/noAutoHeight.html

[Jörn Zaefferer]

The old code calculated the relative difference between the two panels, and took that into account:

var difference = showHeight / hideHeight;
...
var current = (hideHeight - now) * difference;

For autoHeight:false we somehow need to consider the relative difference, too.

[Jörn Zaefferer]

Turns out showProps.height is NaN, overwriting it helps:

showProps.height = showHeight;

Still somewhat laggy.

[Jörn Zaefferer]

A more realistic testcase: ​http://jquery-ui.googlecode.com/svn/trunk/tests/visual/accordion/width.html

[Scott González]

Mostly fixed in r1926.

[Jörn Zaefferer]

Fix width of hidden element before calculating height

[Jörn Zaefferer]

Further improved in r1935. Perfect in FF, not yet in IE.

[Jörn Zaefferer]

In IE: Killing margin-top on p-elements fixes tests/visual/accordion/width.html.

Also not removing the fixed-height seems to fix it, too, but kills the ability to change the accordion content. These lines:

if ( !options.autoHeight ) {
	options.toShow.css("height", "");
}

Seems like margin-top on elements inside the content-element breaks the height calculation, making it too small, causing the jump to a bigger panel once the animation completed and the height-style is removed.

[Scott González]

Closing as fixed as this specific problem has been fixed. Created #4178 for the slight jump that still remains.