Skip to main content

Search and Top Navigation

#4606 closed feature (wontfix)

Opened June 15, 2009 01:56PM UTC

Closed November 16, 2012 03:47PM UTC

Dialog: dialog('disable') does not disable OK/Cancel buttons inside dialog

Reported by: BegemoT Owned by:
Priority: major Milestone: 1.10.0
Component: ui.dialog Version: 1.7.2
Keywords: redesign Cc:
Blocked by: Blocking:

Let me have a dialog with some form inside it, and Save/Cancel buttons. When user press Save I send form data to server via ajax. To prevent user from doing any movements while bytes are running back and forth I disable dialog ( dlg.dialog('disable') ). But this disabling only inputs in my form, not Save/Cancel buttons! I expect them to be disabled too.

Attachments (0)
Change History (11)

Changed June 16, 2009 10:44AM UTC by jzaefferer comment:1

milestone: TBD1.8
type: bugenhancement

Changed November 07, 2009 05:16PM UTC by scottgonzalez comment:2

Changed September 07, 2011 12:39PM UTC by scottgonzalez comment:3

keywords: → redesign
type: enhancementfeature

Changed October 01, 2012 12:40PM UTC by scottgonzalez comment:4

#8610 is a duplicate of this ticket.

Changed October 01, 2012 02:27PM UTC by paladin4ik comment:5

Note that this is not happening only when opening a new dialog but even When calling the disable method of the dialog it only change the UI to semi-transparent. this is not what would be expected from the "Disable" method.

Possible workaround\\ solution:

Then I did the following workaround:

Changed October 11, 2012 02:47PM UTC by scottgonzalez comment:6


Changed October 15, 2012 06:02PM UTC by fontzter comment:7

Some questions related to disabled buttons:

1) If you disable buttons with the dialog this will lock the entire UI if the dialog is modal. Is this desirable?

2) What about the close icon in the header?

3) What about the header itself?...Should the dialog remain draggable in a disabled state?

Changed October 15, 2012 06:46PM UTC by petersendidit comment:8

status: newopen
summary: dialog('disable') does not disable OK/Cancel buttons inside dialogDialog: dialog('disable') does not disable OK/Cancel buttons inside dialog

Changed October 16, 2012 04:12PM UTC by bchiasson comment:9

owner: → bchiasson
status: openassigned

Changed October 16, 2012 05:55PM UTC by bchiasson comment:10

owner: bchiasson
status: assignedopen

Changed November 16, 2012 03:47PM UTC by scottgonzalez comment:11

resolution: → wontfix
status: openclosed

Disabling dialogs doesn't really make sense. You can easily disable the individual buttons if you want. I'm inclined to actually remove the disabled option from dialog.