Opened 10 years ago

Closed 8 years ago

Last modified 8 years ago

#4621 closed bug (fixed)

Tabs: Don't forcefully remove filter attribute

Reported by: Scott González Owned by:
Priority: minor Milestone: 1.9.0
Component: ui.tabs Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Description (last modified by Scott González)

As discussed on jquery-ui-dev, we should deactivate the alpha filter instead of removing the filter attribute. Relies on jQuery #6652.

Change History (5)

comment:1 Changed 9 years ago by Scott González

Description: modified (diff)

comment:2 Changed 8 years ago by Jörn Zaefferer

The underlying jQuery bug was fixed, but in master, _resetStyle still removes the filter attribute. Can we drop that now?

comment:3 Changed 8 years ago by Scott González

Status: newopen

No, because we still support jQuery 1.6.

comment:4 Changed 8 years ago by Scott González

Resolution: fixed
Status: openclosed

Tabs: Don't explicitly remove filter when animating opacity. Fixes #4621 - Tabs: Don't forcefully remove filter attribute.

Changeset: c0f5db539403f1b9c5a80db75d127d4465f911df

comment:5 Changed 8 years ago by Scott González

I changed my mind. There's no reason for us to do any special handling in tabs when core has an officially supported solution. Anyone who needs the correct behavior using jQuery 1.6 - 1.6.2 can just redefine jQuery.cssHooks.opacity.set based on the current jQuery implementation.

Note: See TracTickets for help on using tickets.