Opened 14 years ago

Closed 13 years ago

Last modified 13 years ago

#4645 closed bug (fixed)

Accordion should only manipulate Icons that are children of ui-accordion-header

Reported by: ajpiano Owned by:
Priority: major Milestone: 1.8.3
Component: ui.accordion Version: 1.7.2
Keywords: Cc:
Blocked by: Blocking:

Description

Whether or not it is 100% wise to start having other icons in the accordion header, it should be possible to put icons up there without interference. Hence, this line in _clickHandler is too general: 

this.active.removeClass("ui-state-active ui-corner-top").addClass("ui-state-default ui-corner-all")

.find(".ui-icon").removeClass(o.icons.headerSelected).addClass(o.icons.header);

Change History (4)

comment:1 Changed 14 years ago by Scott González

Milestone: 1.next → 1.8

comment:2 Changed 13 years ago by Jörn Zaefferer

Resolution: → fixed
Status: new → closed

Fixed in ​06f721b

comment:3 Changed 13 years ago by Scott González

Milestone: 1.9 → 1.8.3

comment:4 Changed 13 years ago by Jörn Zaefferer

Use .children() instead of .find() to manipulate accordion icons. Fixes #4645 - Accordion should only manipulate Icons that are children of ui-accordion-header

Changeset: 06f721b74f94272baf5da96133e961f5600f5a90

Note: See TracTickets for help on using tickets.