Sortable: nested sortables sometimes allow recursive drops

[kae]

​http://verens.com/demos/php_and_jquery/8-2-sorting-trees/sorting-trees.php

it is sometimes possible to drag an element into one of its own contained lists.

to replicate this in my link above, just drag the Home item slowly downwards. periodically, you will see the drop marker (the red line) flash inside the Home item itself. if you drop at that point, then the element tries to move into itself and vanishes from view, leaving a browser error.

[kae]

can be solved by adding this to position 644 in ui.sortable.js if($.ui.contains(this.currentItem[0],this.containers[i].element[0]))continue;

[kae]

bug-fix

[kae]

much better patch - use this one instead

[kae]

example of the fixed script in action ​http://verens.com/demos/nested-sortables/nested-sortables.html

compare with demo in main post

[paul]

Fixed in r2999, thanks!

[mvug]

doesn't seem to work quite well in IE8...

[bhellman1]

Hello, I'm interested in trying this patch to allow for nested sortables but the links above are dead. Where can the patch be found / demo?

thxs

[kae]

try this instead: ​http://demo.verens.com/nested-sortables/nested-sortables.html

action is a bit jerky. I remember solving that once, but reverted for some reason that escapes me.

probably easier to use a different plugin for this (jstree for example) until someone with better insight than me figures it out.

[bhellman1]

@Kae, very nice it seems like you got it closer. Maybe CSS is the reason for the jumpyness? I'd love to use JSTREE but sadly it doesn't support moving handlers, which prevents me from putting userinteractable items in the list item like checkboxes comments etc...

Any interest in moving your solution to the next level? Tons of people are looking for this type of solution that allows nested sortables, that can searalize and is built on top of JQUERY UI.

[kae]

I don't have the time at the moment (busy with a 9-5 job, and a book that I'm nearly 2 weeks behind on), but may come back to it in a few weeks.

hmmm... having said that, here's a more stable one: ​http://demo.verens.com/nested-sortables.2/nested-sortables.html

just added back in an old line at L1037:

&& itemElement.parentNode == this.placeholder[0].parentNode only rearrange items within the same container

I can't spare more time on this at the moment.

[eis-os]

Would it be possible to enable the following (mentioned) code again?

&& itemElement.parentNode == this.placeholder[0].parentNode"

This prevents flickering and jumping problems moving nested sortable items into a children that got sortable too. Or at least an option to enable this?

[mikesherov]

Please note that the fixes presented here don't work in IE8 and they'd need to for a patch to be accepted.

[mikesherov]

#4729 is a duplicate of this ticket.

[tj.vantoll]

I ported the only functioning test case listed here over to jsFiddle and I'm not seeing any issues against master - ​http://jsfiddle.net/tj_vantoll/FRy2k/. I tested in Firefox, Chrome, and IE8 since it was explicitly listed.

Can anybody else recreate this?

[mikesherov]

I'm fairly certain this is now fixed, years ago. Leave it as pending in case OP miracously has a new test case.

[kae]

the jsFiddle example appears to be working fine, so consider the problem fixed. I don't have rights to modify the ticket to mark it as done.