Skip to main content

Search and Top Navigation

#4727 closed bug (fixed)

Opened July 28, 2009 06:13PM UTC

Closed November 06, 2012 07:14PM UTC

Last modified March 17, 2013 06:54AM UTC

Dialog: CKEditor in Modal Dialog is not editable

Reported by: lisaj Owned by: lisaj
Priority: minor Milestone: 1.10.0
Component: ui.dialog Version: 1.7.2
Keywords: modal Cc:
Blocked by: Blocking:
Description

Create ckeditor in jquery ui modal dialog an open dialog from ckeditor couse dialog from ckeditor cna not by editable.

I fix it with code in attachment.

Sry my english.

Attachments (2)
  • code.txt (2.2 KB) - added by lisaj July 28, 2009 06:14PM UTC.
  • dialog-patch.js (1.7 KB) - added by AlmogBaku October 08, 2009 11:04PM UTC.

    standalone patch for jquery-dialog & ckeditor

Change History (25)

Changed August 02, 2009 04:38AM UTC by scottgonzalez comment:1

milestone: TBD1.8

The z-index solution may actually be all we need and we could drop the existing dialog ancestor check.

Changed October 08, 2009 10:12PM UTC by AlmogBaku comment:2

Hey lisaj,

I have this problem too.

I don`t understand how did you solve it.

Could you please help me with this section?

Almog Baku.

if you can, please send me mail:

almog.baku@gmail.com

Changed October 08, 2009 10:13PM UTC by AlmogBaku comment:3

Replying to [comment:2 AlmogBaku]:

Hey lisaj, I have this problem too. I don`t understand how did you solve it. Could you please help me with this section? Almog Baku. if you can, please send me mail: almog.baku@gmail.com

** and I dont understand where do you locate this code? in the dialog? in some file?..

Changed October 08, 2009 11:05PM UTC by AlmogBaku comment:4

i got it!

i attach a standalone patch of this soulution.

Changed November 12, 2009 07:33AM UTC by jupeter comment:5

Patch dialog-patch.js fix problem in Firefox (tested in 3.5.5), but not in Google Chrome (4.0.222.5).

Changed November 12, 2009 07:42AM UTC by jupeter comment:6

Replying to [comment:5 jupeter]:

Patch dialog-patch.js fix problem in Firefox (tested in 3.5.5), but not in Google Chrome (4.0.222.5).

sorry, my mistake - work in Google Chrome too :)

Changed November 29, 2010 10:59AM UTC by Lucky comment:7

Replying to [ticket:4727 lisaj]:

Create ckeditor in jquery ui modal dialog an open dialog from ckeditor couse dialog from ckeditor cna not by editable. I fix it with code in attachment. Sry my english.

I met the same issue, but did not find the patched attachment as you said.

Changed November 30, 2010 02:54AM UTC by Lucky comment:8

Replying to [comment:7 Lucky]:

Replying to [ticket:4727 lisaj]: > Create ckeditor in jquery ui modal dialog an open dialog from ckeditor couse dialog from ckeditor cna not by editable. > I fix it with code in attachment. > Sry my english. > I met the same issue, but did not find the patched attachment as you said.

I searched with google and found this patch js file and tried inside my codes, but it does not help to solve this problem, and I also found that, after I switched with "Source", then it works, so I changed to setData(" ") before edit. by this, yes, it works now.

Changed February 16, 2011 01:04PM UTC by scottgonzalez comment:9

#6998 is a duplicate of this ticket.

Changed March 03, 2011 11:10PM UTC by Marshals comment:10

So is there a fix for this? I don't see an attachment and I'm not sure what code the last post is referring to. Thanks

Changed March 03, 2011 11:12PM UTC by Marshals comment:11

Changed September 07, 2011 12:41PM UTC by scottgonzalez comment:12

keywords: → modal

Changed October 11, 2012 02:47PM UTC by scottgonzalez comment:13

milestone: 1.9.01.10.0

Changed October 15, 2012 08:28PM UTC by dcarrith comment:14

summary: In modal dialog con not edit dialog CKEditorDialog: CKEditor in Modal Dialog is not editable

Changed October 15, 2012 08:47PM UTC by dcarrith comment:15

status: newopen

Seems like a valid issue even in latest jQuery UI 1.9 and latest CKEditor downloaded today. However, it's not clear who is at fault. I'll let a core jQuery UI dev team member investigate further.

Changed October 24, 2012 07:55PM UTC by scottgonzalez comment:16

owner: → lisaj
status: openpending

dcarrith or lisaj or anyone else: Can someone please provide a reduced test case showing the problem? I just download CKEditor and put it inside a modal dialog using jQuery UI 1.9.0 and didn't have any problems.

Changed October 26, 2012 11:33AM UTC by mblaney comment:17

I had this problem and have been using the patch mentioned in this ticket. After reading Scott's latest comment, I removed the patch and no longer see the problem. I've also recently switched to jQuery UI 1.9 and the latest ckeditor, so I couldn't tell you how long it's been fixed for or exactly which update it was.

Changed October 26, 2012 12:08PM UTC by mikesherov comment:18

mblaney, thanks for the update! What version of jQuery are you using? 1.8.2? I'm curious to know if there is a combo of CKEditor + jQuery UI + jQuery that works properly for everyone else in this thread, so we can close the loop on this issue.

Changed October 27, 2012 10:25AM UTC by mblaney comment:19

yeah jQuery 1.8.2, jQuery UI 1.9.0 and CKEditor 3.6.4

I just removed the patch from an older install of my software to replicate the problem, and it was still present with versions: jQuery 1.4.2, jQuery UI 1.8.2 and CKEditor 3.3. As you can guess I'm not overly keen on rolling through my commits since then to discover the change that fixed it :-)

Changed October 27, 2012 12:10PM UTC by scottgonzalez comment:20

status: pendingopen

Thanks, that's definitely helpful; we can track it down from here.

Changed November 06, 2012 07:14PM UTC by scottgonzalez comment:21

resolution: → fixed
status: openclosed

CKEditor 3.6.4+ works with old versions of jQuery UI and all versions of CKEditor (only tested back to 3.3) work with jQuery UI Git thanks to 3829a37ca122e923c3a08b964c4b1a946a2a1456.

Closing fixed in 1.10.0 since the old CKEditor problem is actually being fixed by us.

Changed February 15, 2013 11:40PM UTC by smallred comment:22

_comment0: I had a workaround that worked in jQuery UI 1.9.2 to set the zIndex to -1 on the dialog. As far as I can tell this doesn't work with jQuery 1.10.0 and CKEditor 4.1. I had to downgrade to jQuery UI 1.9.2 again. I'm not sure what was fixed in 1.10.0? Because I can't edit any text fields in the CKEditor dialogs still. I've tested in Chrome and Firefox.1360971907744870

I had a workaround that worked in jQuery UI 1.9.2 to set the zIndex to -1 on the dialog. As far as I can tell this doesn't work with jQuery UI 1.10.0 and CKEditor 4.0.1. I had to downgrade to jQuery UI 1.9.2 again. I'm not sure what was fixed in 1.10.0? Because I can't edit any text fields in the CKEditor dialogs still. I've tested in Chrome and Firefox.

Changed February 16, 2013 11:14AM UTC by tj.vantoll comment:23

Replying to [comment:22 smallred]:

I had a workaround that worked in jQuery UI 1.9.2 to set the zIndex to -1 on the dialog. As far as I can tell this doesn't work with jQuery UI 1.10.0 and CKEditor 4.0.1. I had to downgrade to jQuery UI 1.9.2 again. I'm not sure what was fixed in 1.10.0? Because I can't edit any text fields in the CKEditor dialogs still. I've tested in Chrome and Firefox.

See #9087. We're looking into this.

Changed March 10, 2013 12:21PM UTC by TheCyberd3m0n comment:24

Solution is pretty simple. If you use fadeIn(for example 300ms) to show the dialog, just make some delay (using setTimeout) after fading and then replace textarea by CKEditor.

example:

$("selector").dialog({
//parameters
}).fadeIn(300);
setTimeout(function(){CKEDITOR.replace('ckedt-hiddenForms')},350);

Solution works for me fine in Chrome and Internet Explorer. On Mozilla and Opera that problem didn't exist for me...

Changed March 17, 2013 06:54AM UTC by smallred comment:25

_comment0: Replying to [comment:23 tj.vantoll]: \ > Replying to [comment:22 smallred]: \ > > I had a workaround that worked in jQuery UI 1.9.2 to set the zIndex to -1 on the dialog. As far as I can tell this doesn't work with jQuery UI 1.10.0 and CKEditor 4.0.1. I had to downgrade to jQuery UI 1.9.2 again. I'm not sure what was fixed in 1.10.0? Because I can't edit any text fields in the CKEditor dialogs still. I've tested in Chrome and Firefox. \ > \ > See #9087. We're looking into this. \ \ I got it to work using the following code before I create the dialog: \ \ http://bugs.jqueryui.com/ticket/9087 \ \ $.widget("ui.dialog", $.ui.dialog, { \ _allowInteraction: function(event) { \ return !!$(event.target).closest(".cke").length || this._super(event); \ } \ }); \ \ I'm not sure I totally understand the code posted with 9087, but it seems to work fine for me now. I am using jQuery 1.9.1 with jQuery UI 1.10.2.1363503336074919
_comment1: Replying to [comment:23 tj.vantoll]: \ > Replying to [comment:22 smallred]: \ > > I had a workaround that worked in jQuery UI 1.9.2 to set the zIndex to -1 on the dialog. As far as I can tell this doesn't work with jQuery UI 1.10.0 and CKEditor 4.0.1. I had to downgrade to jQuery UI 1.9.2 again. I'm not sure what was fixed in 1.10.0? Because I can't edit any text fields in the CKEditor dialogs still. I've tested in Chrome and Firefox. \ > \ > See #9087. We're looking into this. \ \ I got it to work using the following code before I create the dialog: \ \ http://bugs.jqueryui.com/ticket/9087 \ \ {{{ \ $.widget("ui.dialog", $.ui.dialog, { \ _allowInteraction: function(event) { \ return !!$(event.target).closest(".cke").length || this._super(event); \ } \ }); \ }}} \ \ I'm not sure I totally understand the code posted with 9087, but it seems to work fine for me now. I am using jQuery 1.9.1 with jQuery UI 1.10.2.1363503602082000
_comment2: Replying to [comment:23 tj.vantoll]: \ > Replying to [comment:22 smallred]: \ > > I had a workaround that worked in jQuery UI 1.9.2 to set the zIndex to -1 on the dialog. As far as I can tell this doesn't work with jQuery UI 1.10.0 and CKEditor 4.0.1. I had to downgrade to jQuery UI 1.9.2 again. I'm not sure what was fixed in 1.10.0? Because I can't edit any text fields in the CKEditor dialogs still. I've tested in Chrome and Firefox. \ > \ > See #9087. We're looking into this. \ \ I got it to work using the following code before I create the dialog: \ \ http://bugs.jqueryui.com/ticket/9087 \ \ {{{ \ $.widget("ui.dialog", $.ui.dialog, { \ _allowInteraction: function(event) { \ return !!$(event.target).closest(".cke").length || this._super(event); \ } \ }); \ }}} \ \ I'm not sure I totally understand the code posted with 9087 (some more documentation or examples would be nice), but it seems to work fine for me now. I am using jQuery 1.9.1 with jQuery UI 1.10.2.1363503722239714

Replying to [comment:23 tj.vantoll]:

Replying to [comment:22 smallred]: > I had a workaround that worked in jQuery UI 1.9.2 to set the zIndex to -1 on the dialog. As far as I can tell this doesn't work with jQuery UI 1.10.0 and CKEditor 4.0.1. I had to downgrade to jQuery UI 1.9.2 again. I'm not sure what was fixed in 1.10.0? Because I can't edit any text fields in the CKEditor dialogs still. I've tested in Chrome and Firefox. See #9087. We're looking into this.

I got it to work using the following code before I create the dialog:

http://bugs.jqueryui.com/ticket/9087

$.widget("ui.dialog", $.ui.dialog, {
	_allowInteraction: function(event) {
		return !!$(event.target).closest(".cke").length || this._super(event);
	}
});

I'm not sure I totally understand the code posted with 9087 (some more documentation or examples would be nice), but it seems to work fine for me now. I am using jQuery 1.9.1 with jQuery UI 1.10.2 (required for this fix to work).