Opened 13 years ago
Closed 12 years ago
#5100 closed feature (fixed)
Dialog: remove deprecated dialog option beforeclose
| Reported by: | rdworth | Owned by: | |
|---|---|---|---|
| Priority: | blocker | Milestone: | 1.9.0 |
| Component: | ui.dialog | Version: | 1.8b1 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
The dialog option beforeclose was deprecated by #4669. It should be removed.
Change History (9)
comment:1 Changed 13 years ago by
| Milestone: | 1.next → 1.9 |
|---|---|
| Priority: | minor → blocker |
comment:2 Changed 13 years ago by
| Type: | bug → feature |
|---|
comment:3 Changed 13 years ago by
comment:4 Changed 13 years ago by
beforeclose is already deprecated, it has been renamed to beforeClose. There is an alias and that's what is going away.
comment:5 Changed 13 years ago by
Docs should be updated to reflect this then since it is showing beforeclose as the method name
comment:8 Changed 13 years ago by
The website docs at jqueryui.com/demos are updated at each point release based on what's at docs.jquery.com/UI which is where Scott did the update. So that fix will be live with 1.8.5
comment:9 Changed 12 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
Dialog: Removed handling of deprecated beforeclose option. Fixes #5100 - Dialog: remove deprecated dialog option beforeclose.
Changeset: b42125af4350eda14a6b15bb71f8dd336858fbd8
Note: See
TracTickets for help on using
tickets.
Im confused. So is beforeclose being deprecated altogether? Or is it correctly being renamed to beforeClose? If its only being renamed, I think an alias should exist for current sites using