Skip to main content

Search and Top Navigation

#5100 closed feature (fixed)

Opened January 27, 2010 10:28AM UTC

Closed December 10, 2010 07:32PM UTC

Dialog: remove deprecated dialog option beforeclose

Reported by: rdworth Owned by:
Priority: blocker Milestone: 1.9.0
Component: ui.dialog Version: 1.8b1
Keywords: Cc:
Blocked by: Blocking:

The dialog option beforeclose was deprecated by #4669. It should be removed.

Attachments (0)
Change History (9)

Changed July 30, 2010 03:18PM UTC by scottgonzalez comment:1

milestone: 1.next1.9
priority: minorblocker

Changed July 30, 2010 03:18PM UTC by scottgonzalez comment:2

type: bugfeature

Changed August 09, 2010 05:29PM UTC by etiger13 comment:3

Im confused. So is beforeclose being deprecated altogether? Or is it correctly being renamed to beforeClose? If its only being renamed, I think an alias should exist for current sites using

Changed August 09, 2010 06:04PM UTC by scottgonzalez comment:4

beforeclose is already deprecated, it has been renamed to beforeClose. There is an alias and that's what is going away.

Changed August 09, 2010 06:35PM UTC by etiger13 comment:5

Docs should be updated to reflect this then since it is showing beforeclose as the method name

Changed August 09, 2010 07:36PM UTC by scottgonzalez comment:6

Thanks for pointing that out. I've updated the docs.

Changed August 09, 2010 07:38PM UTC by etiger13 comment:7

Changed August 09, 2010 07:51PM UTC by rdworth comment:8

The website docs at are updated at each point release based on what's at which is where Scott did the update. So that fix will be live with 1.8.5

Changed December 10, 2010 07:32PM UTC by Scott González comment:9

resolution: → fixed
status: newclosed

Dialog: Removed handling of deprecated beforeclose option. Fixes #5100 - Dialog: remove deprecated dialog option beforeclose.

Changeset: b42125af4350eda14a6b15bb71f8dd336858fbd8