Opened 9 years ago

Closed 9 years ago

#5313 closed bug (worksforme)

Modal Dialog's background shadow disappears in Firefox when page scrolls

Reported by: LiamD Owned by:
Priority: critical Milestone: 1.9.0
Component: ui.dialog Version: 1.8rc3
Keywords: Cc:
Blocked by: Blocking:

Description

I have a page that uses the UI dialog in version 1.8rc3. The page scrolls a bit and in IE 8 and chrome the background shadow fills the entire page but in Firefox 3.6 (latest) it only fills the top part of the page. I saw the previous ticket on this (#4995) and that it is to be fixed for 1.8. I was wondering if you were aware of the issue in Firefox and if so is it still scheduled for the 1.8 milestone? In the meantime is there a workaround for this?

Change History (3)

comment:1 Changed 9 years ago by LiamD

fixed this myself locally. In the 1.8rc file circa line 5930 there is the following function for calculating the height of the background shadow.

height: function() { .....

else {

return $(document).height() + 'px';

}

This was returning the height of the visible content in firefox. I changed it to be

if($.browser.mozilla) {

var scrollHeight = Math.max( document.documentElement.scrollHeight, $(document).height() );

return scrollHeight + 'px';

} else {

return $(document).height() + 'px';

}

Think this fix should be ok as it should test for scroll height and which ever is max it will take as the height of the background. works for me any way!

comment:2 Changed 9 years ago by rdworth

Milestone: TBD1.8
Priority: majorcritical

comment:3 Changed 9 years ago by Scott González

Resolution: worksforme
Status: newclosed

This is working fine for me. Please attach a page showing the problem.

Note: See TracTickets for help on using tickets.