Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#5731 closed bug (fixed)

hide and show called with ommiting the options in parameters does not call the callback

Reported by: kobrigo Owned by:
Priority: major Milestone: 1.8.3
Component: ui.effects.core Version: 1.8.2
Keywords: Cc: kobrigo@…
Blocked by: Blocking:

Description

calling $(<some object selector>).hide('slide', 500, function(){

do somthing here });

will work but the callback will not execute.

on the function function _normalizeArguments(effect, options, speed, callback). which tries to do parmas shifting for function overloading.

Workaround could be to add an empty options object like this: some object selector>).hide('slide', {}, 500, function(){

do somthing here });

Attachments (1)

uiBug.zip (54.9 KB) - added by kobrigo 7 years ago.
a test that demostrates the problem ( #div5 should call it's callback)

Download all attachments as: .zip

Change History (5)

Changed 7 years ago by kobrigo

Attachment: uiBug.zip added

a test that demostrates the problem ( #div5 should call it's callback)

comment:1 Changed 7 years ago by kobrigo

calling $(<some object selector>).hide('slide', 500, function(){

do somthing here });

will work but the callback will not execute.

on the function function _normalizeArguments(effect, options, speed, callback). which tries to do parmas shifting for function overloading.

Workaround could be to add an empty options object like this: some object selector>).hide('slide', {}, 500, function(){

do somthing here });

Here is a link to my fix in github

http://github.com/kobrigo/jquery-ui/commit/01dcb63cd3690a2aaf4d0c754b24ecac9c365d81

comment:2 Changed 7 years ago by Scott González

Milestone: TBD1.9
Resolution: fixed
Status: newclosed

Fixed in 1417487. Thanks kobrigo.

comment:3 Changed 7 years ago by Scott González

Milestone: 1.91.8.3

comment:4 Changed 7 years ago by kobrigo

Fixed argument shifting for effects. Fixes #5731 - hide and show called with ommiting the options in parameters does not call the callback.

Changeset: 141748788b034e97337ee7d9d137153c445097fd

Note: See TracTickets for help on using tickets.