Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM

[bgould]

If a dialog has the hide option set and the dialog is destroyed while it is being animated, the effects wrapper remains in the DOM.

$( "#dialog" ).dialog({ hide: "clip" }).dialog( "close" ).dialog( "destroy" );
setTimeout(function() {
    alert( $( ".ui-effects-wrapper" ).length );
}, 1000);

[bgould]

screenshot illustrating problematic div location

[Scott González]

I can't reproduce this. Can you please include a reduced test case? The test case doesn't even need to have tabs on the page, it just needs to show that the effects wrapper exists after the animation completes. Showing that $( ".ui-effects-wrapper" ).length returns a value other than 0 after the animation would suffice.

[swalke16]

​http://jsbin.com/iheka

Here is a simple reproduction case... Note that this problem only happens when you are using an effect on the "hide" option...

[Scott González]

Replying to swalke16:

​http://jsbin.com/iheka

Here is a simple reproduction case... Note that this problem only happens when you are using an effect on the "hide" option...

This is only happening because you're destroying the dialog before the animation completes.

[swalke16]

ahh... cool. Using the close option to pass a callback that does the destroy works a treat! Thanks.

[fontzter]

This appears to be fixed in 1.9. Although the alert in the test case ( ​http://jsbin.com/iheka ) still shows the element, it is removed right after that. Executing $( ".ui-effects-wrapper" ).length in the console returns 0.

[Scott González]

I still see the problem in 1.9.0.

[Jörn Zaefferer]

Still happening in master: ​http://jsbin.com/orozuj/1/edit

[Jörn Zaefferer]

Dialog: Ensure all animations finish and clean up themselve when destroying dialog. Fixes #5860 - Dialog: Destroying a dialog during animated close leaves .ui-effects-wrapper in DOM.

Changeset: 13505e5945e5532c3d56424d50ad109c665d205f