#5945 closed bug (fixed)

Opened August 13, 2010 01:30PM UTC

Closed May 26, 2011 04:28PM UTC

Last modified May 26, 2011 04:30PM UTC

Button: Disabled buttons still allow clicks

Reported by:	spudly	Owned by:
Priority:	minor	Milestone:	1.8.14
Component:	ui.button	Version:	1.8.4
Keywords:	click event disabled	Cc:
Blocked by:		Blocking:

Description

When you disable a button widget, the click events still fire. I expected events to somehow be turned off somehow when the button is disabled, like native button elements.

This only occurs on elements that can't be disabled via the disabled attribute.

Attachments (0)

Change History (17)

Changed January 24, 2011 02:57PM UTC by scottgonzalez comment:1

#6855 is a duplicate of this ticket.

Changed January 24, 2011 02:57PM UTC by scottgonzalez comment:2

milestone:	TBD → 1.9

Changed March 28, 2011 06:14PM UTC by scottgonzalez comment:3

description:	When you disable a button widget, the click events still fire. I expected events to somehow be turned off somehow when the button is disabled, like native button elements. → When you disable a button widget, the click events still fire. I expected events to somehow be turned off somehow when the button is disabled, like native button elements. \ \ This only occurs on elements that can't be disabled via the disabled attribute.
status:	new → open
summary:	Disabled buttons still fire click event → Button: Disabled buttons still allow clicks

Changed May 04, 2011 03:46PM UTC by eikes comment:4

_comment0:	This fixes the problem: \ \ https://github.com/jquery/jquery-ui/pull/198 → 1304599608081107

This fixes the problem:

https://github.com/jquery/jquery-ui/pull/207

Changed May 05, 2011 12:48PM UTC by eikes comment:5

edit: updated pull request number

Changed May 05, 2011 12:49PM UTC by Eike Send comment:6

resolution:	→ fixed
status:	open → closed

Button: stop disabled button from firing click events. fixes #5945. Behavior was inconsisten between BUTTON and A elements.

Changeset: a7f1659cdc99222a733ed2edbd7d00dc57c30227

Changed May 05, 2011 12:49PM UTC by Scott González comment:7

Merge pull request #207 from eikes/bug-5945

Button: stop disabled button from firing click events. fixes #5945.

Changeset: af5b5b19483a0a18abe1fbb43cb534a5485f0804

Changed May 05, 2011 12:50PM UTC by Eike Send comment:8

Button: stop disabled button from firing click events. fixes #5945. Behavior was inconsisten between BUTTON and A elements.

(cherry picked from commit a7f1659cdc99222a733ed2edbd7d00dc57c30227)

Changeset: 4c218eeb0a4e6b06d055fcfe0b45ff034ecbfa43

Changed May 05, 2011 12:50PM UTC by scottgonzalez comment:9

milestone:	1.9 → 1.8.13

Changed May 17, 2011 03:24PM UTC by scottgonzalez comment:10

#5951 is a duplicate of this ticket.

Changed May 24, 2011 06:07PM UTC by JasonC comment:11

Replying to [comment:6 Eike Send]:

Button: stop disabled button from firing click events. fixes #5945. Behavior was inconsisten between BUTTON and A elements. Changeset: a7f1659cdc99222a733ed2edbd7d00dc57c30227

The behavior of disabled anchor elements does not match previous jQuery UI versions. See examples.

jQuery UI 1.8.2: http://jsfiddle.net/JCapriotti/Fw8NC/
jQuery UI 1.8.13: http://jsfiddle.net/JCapriotti/zRNV8/

Also, disabling the hyperlink functionality of anchor elements requires the element to have a click handler that returns false. I believe it has been this way for some time. Is there any way to remove this requirement?

Changed May 24, 2011 06:35PM UTC by scottgonzalez comment:12

milestone:	1.8.13 → 1.9
resolution:	fixed
status:	closed → reopened

Yeah, that should be preventing the default in addition to stopping propagation.

Changed May 25, 2011 04:13PM UTC by JasonC comment:13

Replying to [comment:12 scott.gonzalez]:

Yeah, that should be preventing the default in addition to stopping propagation.

If someone managed to fix it; could it be added to 1.8.14? If so, when would that fix need to happen by?

Changed May 25, 2011 04:54PM UTC by scottgonzalez comment:14

Replying to [comment:13 JasonC]: