#6012 closed bug (fixed)
Dialog: _isOpen flag should be set before triggering open event
Reported by: | dreamershl | Owned by: | |
---|---|---|---|
Priority: | minor | Milestone: | 1.8.5 |
Component: | ui.dialog | Version: | 1.8.4 |
Keywords: | Cc: | ||
Blocked by: | Blocking: |
Description
If you try to open the same dialog box in the open event, the code will re-invoke itself because the _isOpen is false. Is it better that switch the sequence of these 2 lines
from
self._trigger('open'); self._isOpen = true;
to
self._isOpen = true; self._trigger('open');
Change History (4)
comment:1 Changed 12 years ago by
Component: | ui.core → ui.dialog |
---|---|
Milestone: | TBD → 1.9 |
Summary: | show dialog in the open event → Dialog: _isOpen flag should be set before triggering open event |
comment:2 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | new → closed |
comment:3 Changed 12 years ago by
Milestone: | 1.9 → 1.8.5 |
---|
comment:4 Changed 12 years ago by
Dialog: Set the _isOpen flag before triggering the open event. Fixes #6012 - Dialog: _isOpen flag should be set before triggering open event.
Changeset: de02aa34a80eec32ad19e0c83ac88073ee551483
Note: See
TracTickets for help on using
tickets.
Fixed in de02aa3.