Search and Top Navigation
#6012 closed bug (fixed)
Opened September 02, 2010 06:08AM UTC
Closed September 02, 2010 12:36PM UTC
Last modified November 19, 2010 06:26PM UTC
Dialog: _isOpen flag should be set before triggering open event
| Reported by: | dreamershl | Owned by: | |
|---|---|---|---|
| Priority: | minor | Milestone: | 1.8.5 |
| Component: | ui.dialog | Version: | 1.8.4 |
| Keywords: | Cc: | ||
| Blocked by: | Blocking: |
Description
If you try to open the same dialog box in the open event, the code will re-invoke itself because the _isOpen is false. Is it better that switch the sequence of these 2 lines
from
self._trigger('open');
self._isOpen = true;
to
self._isOpen = true;
self._trigger('open');
Attachments (0)
Change History (4)
Changed September 02, 2010 12:22PM UTC by comment:1
| component: | ui.core → ui.dialog |
|---|---|
| milestone: | TBD → 1.9 |
| summary: | show dialog in the open event → Dialog: _isOpen flag should be set before triggering open event |
Changed September 02, 2010 12:36PM UTC by comment:2
| resolution: | → fixed |
|---|---|
| status: | new → closed |
Fixed in de02aa3.
Changed September 10, 2010 05:28PM UTC by comment:3
| milestone: | 1.9 → 1.8.5 |
|---|