Skip to main content

Search and Top Navigation

#6022 closed bug (fixed)

Opened September 05, 2010 03:37AM UTC

Closed March 11, 2011 01:26PM UTC

Last modified May 16, 2012 04:38PM UTC

Effects:explode - multiple explosions cut short

Reported by: stringfold Owned by: gnarf
Priority: minor Milestone: 1.9.0
Component: ui.effects.* (individual effect) Version: 1.8.4
Keywords: Cc:
Blocked by: Blocking:

If you trigger a second explode effect before the first is completed, all the animated image fragments for both animations are removed from the window when the first animation ends.

This is because the callback called when the first animation ends simply calls:


which removes all the image fragments for every animation currently in progress.

This is a shame because everything else works for concurrent explosions works fine -- the animations and the callback function to the user code when the animation is supposed to end.

The fix would be to attach a unique identifier to each set of exploding image elements so the callback can selectively remove only the images for that specific animation.

Attachments (0)
Change History (8)

Changed September 05, 2010 04:02AM UTC by stringfold comment:1

I should add that, if possible, you should be able to select the exploding pieces by the unique identifier -- e.g. for overlapping explosions, you would be able set the z-index to ensure the pieces were displayed in the correct order.

Perhaps an "id" option could be added to the effect API for the explode effect, which would be set to all the exploding pieces. Absent the setting of that option, the code would generate its own unique id to allow the correct removal of only the pieces associated with that explosion.

Changed September 05, 2010 06:21PM UTC by scottgonzalez comment:2

component: ui.coreeffects.* (individual effect)
milestone: TBD1.9

Changed March 06, 2011 08:59PM UTC by gnarf comment:3 - I have a solution in mind

Changed March 07, 2011 05:39PM UTC by gnarf comment:4

owner: → gnarf
status: newassigned

Changed March 08, 2011 10:58AM UTC by gnarf comment:5

blockedby: → 7060

Changed March 11, 2011 04:20AM UTC by gnarf comment:6

Changed March 11, 2011 01:26PM UTC by gnarf comment:7

resolution: → fixed
status: assignedclosed

effects.*: Explode effect was removing more elements than it should upon completion. Fixed #6022 - multiple explosions cut short

Changeset: 4ade64b69028178772d0b9c11fbf7165de160972

Changed May 16, 2012 04:38PM UTC by scottgonzalez comment:8

#8328 is a duplicate of this ticket.