Opened 9 years ago

Closed 7 years ago

#6059 closed bug (fixed)

Button: Primary icon "enabled" when button is disabled

Reported by: kvgeorge1 Owned by: tj.vantoll
Priority: minor Milestone: 1.9.1
Component: ui.button Version: 1.8.4
Keywords: Cc:
Blocked by: Blocking:

Description

When setting a button to state (disabled) in IE8 with a primary icon, the primary icon is not grayed-out like in IE6.

Change History (7)

comment:1 Changed 9 years ago by kvgeorge1

Further research shows that this happens when the DOCTYPE is specified as:

<!DOCTYPE html PUBLIC "-W3CDTD XHTML 1.0 StrictEN"

"http://www.w3c.org/TR/xhtml1/DTD/xhtml1-strict.dtd">

Setting DOCTYPE to <!DOCTYPE html> does not show the problem.

comment:2 Changed 7 years ago by Scott González

Milestone: TBD1.11.0

comment:3 Changed 7 years ago by bchiasson

Owner: set to bchiasson
Status: newassigned
Summary: Button with primary icon when disabled still shows icon as enabled in IE8Button: Primary icon "enabled" when button is disabled
Type: bugfeature

comment:4 Changed 7 years ago by tj.vantoll

Owner: changed from bchiasson to tj.vantoll

IE8 has a bug where elements with relative/absolute positioning do not inherit the opacity value of their parents (http://seanmonstar.com/post/709013028/ie-opacity-ignores-positioned-children).

This can be fixed with the following:

.ui-state-disabled .ui-icon {
    filter:Alpha(Opacity=35);
}

Example: http://jsfiddle.net/tj_vantoll/qMQN5/18/

I'm going to do a little more research to see if this problem applies to other things in UI before sending a pull request.

Last edited 7 years ago by tj.vantoll (previous) (diff)

comment:5 Changed 7 years ago by tj.vantoll

This problem also occurs on disabled inline datepickers. After discussion we couldn't think of any adverse effects of the fix shown in the above comment.

Pull request: https://github.com/jquery/jquery-ui/pull/771

comment:6 Changed 7 years ago by Scott González

Milestone: 1.11.01.9.1
Type: featurebug

comment:7 Changed 7 years ago by TJ VanToll

Resolution: fixed
Status: assignedclosed

CSS: Apply opacity to absolutely positioned ui icons in IE8. Fixed #6059 - Button: Primary icon "enabled" when button is disabled.

Changeset: fe1ecf97e01f6b9e6041ae324deafb69063d1c9c

Note: See TracTickets for help on using tickets.