#6067 closed bug (fixed)
Dialog show/hide animations do not work
Reported by: | chrisbarr | Owned by: | |
---|---|---|---|
Priority: | major | Milestone: | 1.8.6 |
Component: | ui.dialog | Version: | 1.8.5 |
Keywords: | animation, show, animate, dialog | Cc: | |
Blocked by: | Blocking: |
Description
Since the 1.8.5 update, when setting a custom animation to show or hide a dialog they do not take. It just uses the default .show(500) animation instead.
Here's the basic code I used. In 1.8.4 this would have animated properly.
$("myElement").dialog({ show:{ effect:"fade", duration:500, easing:"easeOutExpo" }, hide:{ effect:"drop", direction:"down", distance:100, duration:500, easing:"easeOutExpo" } });
Change History (7)
comment:1 follow-up: 2 Changed 12 years ago by
Resolution: | → worksforme |
---|---|
Status: | new → closed |
comment:2 Changed 12 years ago by
Resolution: | worksforme |
---|---|
Status: | closed → reopened |
Replying to scott.gonzalez:
Works for me: http://jsbin.com/eceta3
Scott, please take another look at your example. Yes it does animate but the animations are not correct - which is why I posted this ticket in the first place.
Go back and look and you'll see that the opening animation is a standard jQuery .show(500) and not a fade. The closing animation is a standard jQuery .hide(500) and not the drop effect.
comment:3 Changed 12 years ago by
Milestone: | 1.next → 1.9 |
---|
Sorry, I think I had actually done my testing with an earlier version and when I saw it was working bumped the version up, saw that it still animated (must not have paid attention to the actual animation) and thought it worked.
comment:4 Changed 12 years ago by
Resolution: | → fixed |
---|---|
Status: | reopened → closed |
Summary: | Custom dialog show/hide animations do not work → Dialog show/hide animations do not work |
Fixed in ce08df3.
comment:5 Changed 12 years ago by
Awesome, thanks so much. I patched my copy of jQuery UI with this fix and everything works great now.
comment:6 Changed 12 years ago by
Milestone: | 1.9 → 1.8.6 |
---|
comment:7 Changed 12 years ago by
Effects: Fixed .show(), .hide(), .toggle() to accept a hash of options again. Fixes #6078 - Effects: Passing an object for parameters no longer works. Fixes #6067 - Dialog show/hide animations do not work.
Changeset: ce08df3bdc8f2806062f7a393975656f31cda035
Works for me: http://jsbin.com/eceta3