Skip to main content

Search and Top Navigation

#6067 closed bug (fixed)

Opened September 17, 2010 07:20PM UTC

Closed September 20, 2010 02:09PM UTC

Last modified November 19, 2010 06:26PM UTC

Dialog show/hide animations do not work

Reported by: chrisbarr Owned by:
Priority: major Milestone: 1.8.6
Component: ui.dialog Version: 1.8.5
Keywords: animation, show,animate,dialog Cc:
Blocked by: Blocking:

Since the 1.8.5 update, when setting a custom animation to show or hide a dialog they do not take. It just uses the default .show(500) animation instead.

Here's the basic code I used. In 1.8.4 this would have animated properly.

Attachments (0)
Change History (7)

Changed September 17, 2010 07:27PM UTC by scottgonzalez comment:1

resolution: → worksforme
status: newclosed

Works for me:

Changed September 20, 2010 01:44PM UTC by chrisbarr comment:2

resolution: worksforme
status: closedreopened

Replying to [comment:1 scott.gonzalez]:

Works for me:

Scott, please take another look at your example. Yes it does ''animate'' but the animations are not correct - which is why I posted this ticket in the first place.

Go back and look and you'll see that the opening animation is a standard jQuery ''.show(500)'' and not a fade. The closing animation is a standard jQuery ''.hide(500)'' and not the drop effect.

Changed September 20, 2010 01:54PM UTC by scottgonzalez comment:3

milestone: 1.next1.9

Sorry, I think I had actually done my testing with an earlier version and when I saw it was working bumped the version up, saw that it still animated (must not have paid attention to the actual animation) and thought it worked.

Changed September 20, 2010 02:09PM UTC by scottgonzalez comment:4

resolution: → fixed
status: reopenedclosed
summary: Custom dialog show/hide animations do not workDialog show/hide animations do not work

Fixed in ce08df3.

Changed September 20, 2010 07:22PM UTC by chrisbarr comment:5

Awesome, thanks so much. I patched my copy of jQuery UI with this fix and everything works great now.

Changed October 25, 2010 06:53PM UTC by scottgonzalez comment:6


Changed November 19, 2010 06:26PM UTC by Scott González comment:7

Effects: Fixed .show(), .hide(), .toggle() to accept a hash of options again. Fixes #6078 - Effects: Passing an object for parameters no longer works. Fixes #6067 - Dialog show/hide animations do not work.

Changeset: ce08df3bdc8f2806062f7a393975656f31cda035