Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#6131 closed bug (fixed)

Dialog breaks when $.fx.off

Reported by: chrisbarr Owned by:
Priority: critical Milestone: 1.8.6
Component: ui.dialog Version: 1.8.5
Keywords: no effects, FX, fx.off, dialog Cc:
Blocked by: Blocking:

Description

Dialogs (especially animated ones) seem to do nothing at all when $.fx.off is set to true.

To test this, go to the dialog demo: ​http://jqueryui.com/demos/dialog/animated.html Then open Firebug (or your preferred JS console) and type $.fx.off=true;

Press the "open dialog" button on the demo and nothing will happen.

The dialog widget should respect the $.fx.off property in jQuery and not try to animate the dialog when it can't.

Change History (3)

comment:1 Changed 6 years ago by scottgonzalez

  • Milestone changed from 1.next to 1.9
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in ​3b38025.

comment:2 Changed 6 years ago by scottgonzalez

  • Milestone changed from 1.9 to 1.8.6

comment:3 Changed 6 years ago by Scott González

Effects: Jump to final state and execute callbacks when $.fx.off is set to true. Fixes #6131 - Dialog breaks when $.fx.off. Partial fix for #5512 - jQuery.fx.off and effect on jQuery UI Effects.

Changeset: 3b38025cedca458c100176c273c8d3956a7a5459

Note: See TracTickets for help on using tickets.