Skip to main content

Search and Top Navigation

#6131 closed bug (fixed)

Opened September 30, 2010 09:19PM UTC

Closed October 04, 2010 06:54PM UTC

Last modified November 19, 2010 06:26PM UTC

Dialog breaks when $.fx.off

Reported by: chrisbarr Owned by:
Priority: critical Milestone: 1.8.6
Component: ui.dialog Version: 1.8.5
Keywords: no effects, FX, fx.off,dialog Cc:
Blocked by: Blocking:
Description

Dialogs (especially animated ones) seem to do nothing at all when ''$.fx.off'' is set to ''true''.

To test this, go to the dialog demo: http://jqueryui.com/demos/dialog/animated.html

Then open Firebug (or your preferred JS console) and type ''$.fx.off=true;''

Press the "open dialog" button on the demo and nothing will happen.

The dialog widget should respect the $.fx.off property in jQuery and not try to animate the dialog when it can't.

Attachments (0)
Change History (3)

Changed October 04, 2010 06:54PM UTC by scottgonzalez comment:1

milestone: 1.next1.9
resolution: → fixed
status: newclosed

Fixed in 3b38025.

Changed October 25, 2010 06:52PM UTC by scottgonzalez comment:2

milestone: 1.91.8.6

Changed November 19, 2010 06:26PM UTC by Scott González comment:3

Effects: Jump to final state and execute callbacks when $.fx.off is set to true. Fixes #6131 - Dialog breaks when $.fx.off. Partial fix for #5512 - jQuery.fx.off and effect on jQuery UI Effects.

Changeset: 3b38025cedca458c100176c273c8d3956a7a5459