Skip to main content

Search and Top Navigation

#6137 closed bug (fixed)

Opened October 01, 2010 10:39PM UTC

Closed October 04, 2010 01:20PM UTC

Last modified November 19, 2010 06:26PM UTC

dialog('open') causes form elements to reset on IE7

Reported by: john.firebaugh Owned by:
Priority: minor Milestone: 1.8.6
Component: ui.dialog Version: 1.8.5
Keywords: Cc:
Blocked by: Blocking:
Description

If you use multiple dialogs on a page, and one has a form with radio buttons, on IE7 the checked radio button will reset to the default when the dialog is opened.

Test case:

test("dialog on IE7 should not reset form elements when opening", function() {
	expect(2);

	d1 = $('<form><input type="radio" name="radio" id="a" value="a" checked="checked"></input>' +
				'<input type="radio" name="radio" id="b" value="b">b</input></form>').dialog({autoOpen: false});

	d1.find('#b')[0].checked = true;
	equal($('input:checked').val(), 'b', "checkbox b is checked");

	d2 = $('<div></div>').dialog({autoOpen: false});

	d1.dialog('open');
	equal($('input:checked').val(), 'b', "checkbox b is checked"); // Fails

	d1.add(d2).remove();
})
Attachments (0)
Change History (6)

Changed October 01, 2010 10:48PM UTC by john.firebaugh comment:1

Changed October 04, 2010 01:20PM UTC by scottgonzalez comment:2

component: ui.coreui.dialog
milestone: TBD1.9
resolution: → fixed
status: newclosed

Fixed in e66cdfc.

Changed October 25, 2010 07:00PM UTC by scottgonzalez comment:3

milestone: 1.91.8.6

Changed November 19, 2010 06:26PM UTC by Scott González comment:4

Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.

Changeset: 67b1db14c964418ce8b1fd760d54761040cc32af

Changed November 19, 2010 06:26PM UTC by Scott González comment:5

Revert "Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7."

This reverts commit 67b1db14c964418ce8b1fd760d54761040cc32af.

Reverting so I can commit again with the proper author.

Changeset: c090802cc1f92736288dafbea95bb2783392975e

Changed November 19, 2010 06:26PM UTC by John Firebaugh comment:6

Dialog: Don't change DOM position on open. Fixes #6137 - dialog('open') causes form elements to reset on IE7.

Changeset: e66cdfcf59f3a03bb3c49337f8c11da0a236b337