Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#6150 closed bug (fixed)

Dialog height:auto does not work in IE6

Reported by: aebond Owned by:
Priority: major Milestone: 1.8.6
Component: ui.dialog Version: 1.8.5
Keywords: dialog height Cc:
Blocked by: Blocking:

Description

The height:'auto' option is not working in IE6 with jquery-ui v1.8.5. It previously worked fine in IE6 with jquery-ui v1.7.2.

Attachments (4)

dialog_test.html​ (1.0 KB) - added by aebond 7 years ago.
html to reproduce problem
ie6_dialog.png​ (25.7 KB) - added by aebond 7 years ago.
Screenshot of behavior in IE6
ie6_dialog_height.png​ (12.8 KB) - added by seb835 7 years ago.
Screen shot of continuing problem in IE6
test.html​ (1.2 KB) - added by seb835 7 years ago.
html to reproduce continuing problem

Download all attachments as: .zip

Change History (11)

Changed 7 years ago by aebond

Attachment: dialog_test.html​ added

html to reproduce problem

Changed 7 years ago by aebond

Attachment: ie6_dialog.png​ added

Screenshot of behavior in IE6

comment:1 Changed 7 years ago by Scott González

Milestone: TBD → 1.9
Resolution: → fixed
Status: new → closed

Fixed in ​302728b.

Changed 7 years ago by seb835

Attachment: ie6_dialog_height.png​ added

Screen shot of continuing problem in IE6

Changed 7 years ago by seb835

Attachment: test.html​ added

html to reproduce continuing problem

comment:2 Changed 7 years ago by seb835

Resolution: fixed
Status: closed → reopened

Problem still exists in IE6 where the dialog content starts as empty, and content is then added-in at the point of the dialog open function (see new file uploads)

comment:3 Changed 7 years ago by Scott González

Resolution: → fixed
Status: reopened → closed

Your test page is using 1.8.5 which is the version the bug was reported in. The fix has not been released yet.

comment:4 in reply to:  3 Changed 7 years ago by seb835

Replying to scott.gonzalez:

Your test page is using 1.8.5 which is the version the bug was reported in. The fix has not been released yet.

Yes, I apologise I should have been clearer. I had copied-in the fix (302728b) to my code, and while it did fix the auto-height issue when pre-entered content, when filling the dialog with .apend(), the auto-height bug returned as pictured in my screen shot.

comment:5 Changed 7 years ago by Scott González

Thanks for clarifying. I've created #6217 for this as it's actually a separate problem.

comment:6 Changed 7 years ago by Scott González

Milestone: 1.9 → 1.8.6

comment:7 Changed 7 years ago by Scott González

Dialog: Fixed logic for mimicking minHeight. Fixes #6150 - Dialog height:auto does not work in IE6.

Changeset: 302728bd87dca0a887e25bac7a8a7059865a42af

Note: See TracTickets for help on using tickets.